Fixing two recognize-gesture deprecation messages

[lupestro]

Updated recognize-gesture modifier to use latest ember-modifier (fixes one deprecation) Fixed recognize-gesture invocation of -gestures service during render (fixes the other)

Using ember-modifier requires a minimum of Ember 3.3 (rather than 3.1) for ember-destroyable-plugin, which it calls internally, to function. Not sure if that qualifies this fix to be a sem-ver major bump, but I suspect so.

I'll defer updating the changelog until I hear what the committers want to do.

[lupestro]

The travis-ci failures in LTS 2.12, 2.16, 2.18 are expected with this change. We're effectively reducing the range of Ember versions with which this will work so that the modifier will work without deprecations in recent versions of Ember. It will definitely need a new major version to insulate users of Ember < 3.3 from the change.

[pieter-v]

@lupestro Using this branch, I have exceptions in willRemove during rerender my component. Would it be possible to change

willRemove() {
  this.manager.destroy();
  this.manager = null;
}

to

willRemove() {
  if (this.manager !== null) {
    this.manager.destroy();
    this.manager = null;
  }
}

[lupestro]

Hi @pieter-v - I swung back around here, doing maintenance on a related project, and stumbled over your comment from back in March. I'll make the fix shortly. Sorry for the long delay.

[pieter-v]

@lupestro thanx

[veelci]

@lupestro Any updates on this? I just upgraded an application to Ember 3.28 and am running into #138