nupic.audio icon indicating copy to clipboard operation
nupic.audio copied to clipboard

make this repo pip installable

Open breznak opened this issue 9 years ago • 18 comments

so it can be conveniently used along nupic.

It should be possible to install with: python setup.py install which will install content of nupic/audio/ and make it accessible from anywhere with: python -c 'from nupic.audio.encoders.wave import WAVEncoder'

breznak avatar May 02 '16 17:05 breznak

@rhyolight do you remember who made the pip version e.g. of nupicvision? Would be really nice if they could help us quickly implement the same for this repo. Not the experiments themselves, but the "common" part nupicaudio/ as presented in #26 (dependencies: scipy)

breznak avatar May 06 '16 09:05 breznak

@breznak I don't know but maybe Scott, but don't bother him please, he's pretty busy. This should be a trivial task for any experienced python programmer. If you can't find anyone, maybe I could do it next week.

rhyolight avatar May 06 '16 15:05 rhyolight

@breznak I'm not sure what the point would be to lock this repo into a pip install-able state, as opposed to git cloning it. In the future I can imagine changes, such as custom encoders, could be moved from here into the main nupic/nupic.core repository. But until then fail to see why this repo requires packaging?

rcrowder avatar May 08 '16 12:05 rcrowder

@rcrowder uhm..I haven't been very descriptive in the issue, I definitely don't mean to include the experiments. Just the nupicaudio/ subfolder with encoders or any generic-useful stuff.

breznak avatar May 09 '16 13:05 breznak

@rcrowder @passiweinberger nupic/ content is now a submodule of nupic and is installable with setup.py , ...OK, this is what I meant with "pip installable".

Hope you guys are OK with that?

Also, if you want, it would be nice if you could add requirements of your experiments to requirements.txt (commented out, as the experiments are optional)

breznak avatar May 12 '16 09:05 breznak

Check! 🚀🤓 I think having the requirements in each experiment separately is easier and leaner :)

I'll sit on it tmw!

--Pascal

Best,

Pascal Weinberger


Co-Founder & CTO GAIA Solutions Ltd. meetGaia.com

BE THE CHANGE YOU WANT TO SEE IN THE WORLD ...

PLEASE NOTE: This email and any file transmitted are strictly confidential and/or legally privileged and intended only for the person(s) directly addressed. If you are not the intended recipient, any use, copying, transmission, distribution, or other forms of dissemination is strictly prohibited. If you have received this email in error, please notify the sender immediately and permanently delete the email and files, if any. Please consider the environment before printing this message.

On 12 May 2016, at 11:43, breznak [email protected] wrote:

@rcrowder @passiweinberger nupic/ content is now a submodule of nupic and is installable with setup.py , ...OK, this is what I meant with "pip installable".

Hope you guys are OK with that?

Also, if you want, it would be nice if you could add requirements of your experiments to requirements.txt (commented out, as the experiments are optional)

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

passiweinberger avatar May 12 '16 09:05 passiweinberger

having the requirements in each experiment separately is easier and leaner

True, that would be best imho :+1:

Also, when you are at checking your experiment, please take a look at #26 if you could find a use for it

breznak avatar May 12 '16 09:05 breznak

#28

passiweinberger avatar May 12 '16 10:05 passiweinberger

Reopening as #26 is not working with this! Please help me with:

python setup.py install
python -c "import nupic.audio"

breznak avatar May 12 '16 10:05 breznak

@rhyolight I'm stuck here with setup.py, copied the examples from nupic/nupic.vision + searched help. Btw, it seems setup.py in nupic.vision is not working either(?) Can you suggest someone to help? @david-ragazzi do you know setup.py files?

breznak avatar May 12 '16 12:05 breznak

@breznak I'll take a look at the setup.py stuff in a bit...

rhyolight avatar May 12 '16 15:05 rhyolight

:+1: cool Matt, thanks a lot!

breznak avatar May 12 '16 15:05 breznak

@breznak So it didn't work?

rhyolight avatar May 13 '16 16:05 rhyolight

Nope :disappointed: I've added validation instructions in the Issue description:

python setup.py install which will install content of nupic/audio/ and make it accessible from anywhere with: python -c 'from nupic.audio.encoders.wave import WAVEncoder'

What I can do is cd nupic/ and python -c 'from audio.encoders.wave import WAVEncoder; but I could that even before and it is not what we want (i think?) We want absolute imports to work!

PS: I'm not sure if the namespace package is suitable for this repo? (but didn't work even w/o it imho).

CC @rhyolight

breznak avatar May 13 '16 16:05 breznak

I thought he problem was with scipy. When I ran pip install -r requirements.txt, it worked fine, but declaring scipy or numpy in the install_requires block kept throwing that TypeError, and I don't know why.


Matt Taylor OS Community Flag-Bearer Numenta

On Fri, May 13, 2016 at 9:28 AM, breznak [email protected] wrote:

Nope [image: :disappointed:] I've added validation instructions in the Issue description:

python setup.py install which will install content of nupic/audio/ and make it accessible from anywhere with: python -c 'from nupic.audio.encoders.wave import WAVEncoder'

What I can do is cd nupic/ and python -c 'from audio.encoders.wave import WAVEncoder; but I could that even before and it is not what we want (i think?) We want absolute imports to work!

PS: I'm not sure if the namespace package is suitable for this repo? (but didn't work even w/o it imho).

CC @rhyolight https://github.com/rhyolight

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/nupic-community/nupic.audio/issues/24#issuecomment-219092785

rhyolight avatar May 13 '16 16:05 rhyolight

@breznak I tried last weekend to get this as a submodule of nupic. But couldn't get it work. I'll have another look this weekend.

rcrowder avatar May 19 '16 12:05 rcrowder

@rcrowder did you have any luck? I'll give it a try too.

breznak avatar May 22 '16 15:05 breznak

@breznak I'm having another look now. It takes a while to reconfigure my system to cope with nupci forcing older package install (e.g. numpy==1.9.2), but you're last merge here looks like it has gone a long way towards getting it to work.

rcrowder avatar May 22 '16 16:05 rcrowder