Heiko Thiery

> I have checked the Codacy Static Code Analysis reports. It have conflict with using hard coded password and the Popen function from the subprocess library. But I wanted to...

> @hthiery Hi!) Is there any update on this PR? I just see that calling ipmitool with popen and `Shell=True` is an issue . Using e.g.: `./ipmitool.py -vv -I ipmitool...

Looks good. Could you please add some tests for your change?

Sorry for the late reaction .. Thanks for the changes.

I dont think so .. the PKG config file `vulkan.pc` lying under my cross compile sysroot is found. There the `prefix` is set to `/usr`. With ``` vk_xml = join_paths([...

> I assume there must be some mapping going on: > > ``` > 🕙15:09:26 alex@draig:buildroot.git/builds/arm64 on  add-virtio-vulkan-vkmark:master [$?⇡] took 47m18s > ➜ find . -iname "vulkan.pc" > ./host/aarch64-buildroot-linux-gnu/sysroot/usr/lib/pkgconfig/vulkan.pc...

> Ahh [@hthiery](https://github.com/hthiery) yes you were right, I had a /usr/share/vulkan/registery/vk.xml on my system. Without it the build broke. Ok, great. I was already wondering. Then I got it right...

Hi, just re-tried things you did above. I figured out that in case of `zlib` there are 2 `zlib.pc` files: ``` output/host/lib/pkgconfig/zlib.pc output/host/i686-buildroot-linux-gnu/sysroot/usr/lib/pkgconfig/zlib.pc ``` Reason for that is it is...

``` --- a/src/meson.build +++ b/src/meson.build @@ -1,7 +1,13 @@ prog_python = find_program('python3') +if meson.is_cross_build() + vulkan_prefix = meson.get_cross_property('sys_root') + vulkan_dep.get_pkgconfig_variable('prefix') +else + vulkan_prefix = vulkan_dep.get_pkgconfig_variable('prefix') +endif + vk_xml = join_paths([...

> [@hthiery](https://github.com/hthiery) see the branch I've pushed as an alternative. Great! With that fix I can build the package in buildroot.