petty-af icon indicating copy to clipboard operation
petty-af copied to clipboard

Brainstorming more petty things to snark on?

Open stuartpb opened this issue 6 years ago • 1 comments

Here are some of my own personal pet peeves:

  • Using Harmony language features without "use strict" (I am fully guilty of this one on a regular basis, and I realize it every time I deploy to an Ubuntu LTS system where Node is older than ~6.x)
  • Using === in a situation where you actually want equality to be checked on a type-coercive basis (though I have no idea how you'd gauge this based on the AST)
  • Various complaints about whitespace:
    • Mixing tabs and spaces
    • Whitespace at end of line
    • No newline at end of file
    • Lines that don't use whitespace in any place where it'd be valid ("why are you postprocessing this if you've already minified it?")
    • Entire lines that use whitespace in every place it could be valid (eg. new Date ( 1989 , 5 , 28 ) . toISOString ( ))

Also, what about a config option to decide whether the processor complains about using semicolons, or not using semicolons?

stuartpb avatar Jan 22 '19 19:01 stuartpb

variable names in 2...5 range that arent real words

makc avatar Sep 27 '19 12:09 makc