issue_stats icon indicating copy to clipboard operation
issue_stats copied to clipboard

Requesting an non-existing repo doesn't return 404

Open satazor opened this issue 9 years ago • 0 comments

A request to http://issuestats.com/github/rails/foobar?format=json does not return a 404 status nor a valid json response, it simply renders a "Page does not exist".

Would you be interested in solves this? Thanks

satazor avatar Feb 07 '16 10:02 satazor

Hi, You need to use dbCloumn to store the filename once transformed.

Example:

'transforms' => array(
                    'imageSmall' => array(
                        'class' => 'crop',
                        'append' => '-small',
                        'overwrite' => true,
                        'self' => false,
                        'width' => 138,
                        'height' => 118,
                        'nameCallback' => 'transformNameCallback',
                        'dbColumn' => 'thumbnail',
                    ),
                ),

In this case I used field named "thumbnail" to store the filename. Have a try.

zhaff avatar Jan 11 '15 08:01 zhaff

@richcom: I too am having that problem. I tried removing the nameCallback from the transform and still the same. I do however have a lot of other files that I am dealing with with this uploader (config for example) and the error I am getting is that it is looking for the config finalPath provided which references another image and model completely. For me it deletes the transformed image and not the original.

I am using Version 4.6.0 with CakePHP Version 2.5.8.

'Uploader.Attachment' => array(
    'config' => array(
        'finalPath' => '/files/item-configs/',
        'dbColumn' => 'name_original',
        'nameCallback' => 'formatName',
        'overwrite' => false,
        'stopSave' => true,
        'allowEmpty' => true,
        'metaColumns' => array(
            'ext' => 'ext',
            'type' => 'file_type',
            'size' => 'size'
        )
    ),
    'part_icon' => array(
        'finalPath' => '/files/part-icons/',
        'dbColumn' => 'name_original',
        'nameCallback' => 'formatName',
        'overwrite' => false,
        'stopSave' => true,
        'allowEmpty' => true,
        'metaColumns' => array(
            'ext' => 'ext',
            'type' => 'file_type',
            'size' => 'size',
            'width' => 'width',
            'height' => 'height'
        ),
        'transforms' => array(
            'thumb' => array(
                'class' => 'crop',
                'nameCallback' => 'formatName',
                'append' => '-thumb',
                'overwrite' => true,
                'width' => 250,
                'height' => 250
            )
        )
    )
);

@zhaff: The 'imageSmall' key takes care of the dbColumn so you don't have to repeat it in the array. I did test and if you provide the dbColum, it does overwrite the 'imageSmall' key and save to whatever you name it however it isn't necessary since it is already handled.

bradmaxs avatar Jan 27 '15 00:01 bradmaxs

What versions of Cake are you all using?

milesj avatar Jan 27 '15 04:01 milesj

It seems that other images are not being deleted now.

I am using Version 4.6.0 with CakePHP Version 2.5.8.

I checked my error logs in cake after deleting an image (this time without transformation) and it has the wrong path even though the right one is stored in the db.

Let's say I am trying to delete /files/part-icon/ba1fcc2a10897dd417ec7e6408a7c7e3.stl

The error I am getting is /files/item-configs/ba1fcc2a10897dd417ec7e6408a7c7e3.stl does not exist

Seems it is getting stuck on the first directory in the Attachment array.

Thanks Miles.

bradmaxs avatar Jan 30 '15 23:01 bradmaxs