electron-cookies

electron-cookies copied to clipboard

Example of using Google Analytics with `electron-cookies`

11

Is there an example of using GA with `electron-cookies`? I'm a bit confused on how to get started. Thanks!

owenthereal

Please could we use an internal domain name - i.e. one that cannot be registered? E.g. just `electron-renderer` would be fine.

ljwagerfield

add limitations section to README

1

Addresses #12

transitive-bullshit

Make it clear this doesn't provide normal browser cookie behavior

2

Normally, the browser will send cookies automatically based on the request domain and set cookies based on response set-cookie headers. It'd be nice to add something to the README explaining...

transitive-bullshit

Cookie expiration

2

Have you given any thought to cookie expiration? ``` key=value; Expires=Thu, 01-Jan-1970 00:00:01 GMT ```

sean3z

when running the application on localhost made by node server in electron then it throws an error that the 'electron-cookies' module is not found. Please help

bansalvks

Added support for proper cookie string with Expiration, but the expiration didn't work yet.

2

loming

Cookies read from storage every request

1

Have you given any thought to optimizing this a bit by ensuring the entire cookie storage (`locaStorage.cookies`) isn't read and parsed on every cookie request? While the current implementation works...

sean3z

Just suggesting an additional test to ensure that existing values are updated as expected. When browsing this library for usage/functionality, I noticed this piece missing. :)

sean3z