HUnit icon indicating copy to clipboard operation
HUnit copied to clipboard

Handle GHC 9.8's x-partial warning, requires dropping GHC 7

Open andreasabel opened this issue 1 year ago • 3 comments

Fixing a use of tail in the library. In the test-suite, tail [] is intended, so switch off the x-partial there.

Ignoring -Wx-partial on older GHCs requires -Wno-unrecognised-warning-flags, which entered GHC only in 8.0. Thus, dropping GHC 7.

Closes #56.

andreasabel avatar Jul 30 '24 07:07 andreasabel

CI run on my fork: https://github.com/andreasabel/HUnit/pull/1

macos-latest fails due to:

  • https://github.com/hspec/setup-haskell/issues/44

andreasabel avatar Jul 30 '24 07:07 andreasabel

CI run on my fork: andreasabel#1

macos-latest fails due to:

I think this can be fixed by using macos-12.

sol avatar Aug 01 '24 21:08 sol

If we drop support for GHC 7.* then there is some CPP that can be removed as well, e.g.

https://github.com/hspec/HUnit/blob/main/src/Test/HUnit/Lang.hs#L5

https://github.com/hspec/HUnit/blob/main/src/Test/HUnit/Base.hs#L6

sol avatar Aug 01 '24 21:08 sol