blixt-wallet icon indicating copy to clipboard operation
blixt-wallet copied to clipboard

Reports of Blixt crashing when paying

Open hsjoberg opened this issue 3 years ago • 1 comments

com.facebook.react.common.JavascriptException: TypeError: Cannot read property 'length' of undefined, js engine: hermes, stack:
getLens@1:208315
toByteArray@1:208548
decodeStreamResult@1:2384655
decodeSendPaymentV2Result@1:2622749
anonymous@1:2623497
emit@1:88057
__callFunction@1:167155
anonymous@1:165773
__guard@1:166720
callFunctionReturnFlushedQueue@1:165731

at com.facebook.react.modules.core.ExceptionsManagerModule.reportException(Unknown Source
  at java.lang.reflect.Method.invoke (Native Method)
  at com.facebook.react.bridge.JavaMethodWrapper.invoke (Unknown Source:148)
  at com.facebook.react.bridge.JavaModuleWrapper.invoke (Unknown Source:147)
  at com.facebook.react.bridge.queue.NativeRunnable.run (Native Method)
  at android.os.Handler.handleCallback (Handler.java:938)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage (Unknown Source)
  at android.os.Looper.loop (Looper.java:236)
  at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run (Unknown Source:37)
  at java.lang.Thread.run (Thread.java:923)

AFAICT it looks like the protobufs have to be updated.

hsjoberg avatar Nov 03 '21 17:11 hsjoberg

Not sure what's wrong just yet. Will roll out some mitigation attempts.

It can be completely circumvented by try/catch-ing the callback (apparently it won't be propagated to SendConfirmation if it's inside a LndMobileEventEmitter.addListener event, but then underlying error will go not return a crash anymore, only an error for the user.

hsjoberg avatar Nov 04 '21 00:11 hsjoberg