encoding_rs

encoding_rs copied to clipboard

set_len on a Vec<u8> of uninit is UB

8

encoding_rs currently has UB in the form of creating uninitialized u8's via set_len Here are 2 examples where the UB is crystal clear: https://github.com/hsivonen/encoding_rs/blob/dd9d99bb185f93d4fe5071291cdc54278e193955/src/mem.rs#L2007-L2010 https://github.com/hsivonen/encoding_rs/blob/dd9d99bb185f93d4fe5071291cdc54278e193955/src/mem.rs#L2044-L2047 set_len is also used in...

nico-abram

Fix clippy lints

1

This PR fixes clippy lints that showed up on clippy 1.56.1 Lints that showed up multiple times were: - Add clippy:: prefix to lint allow()s - Use matches! - Replace...

nico-abram

In the common case when converting from UTF8 to UTF8, or the string is all ASCII, this avoids an extra heap allocation for the caller if they only have a...

jyn514

0.8.29 should be a major bump

3

Commit https://github.com/hsivonen/encoding_rs/commit/cecda92386d0e1db7961e25690e86bdabfaee064 introduces an `alloc` feature and adds it to the defaults. Unfortunately this breaks semver, in particularly for those crates that use cargo parametr `default-features = false`. As an...

l4l

The front page of the docs say "Decode using the streaming API with minimal unsafe" but the example doesn't actually unsafe at all AFAICT. Maybe it used to?

jgarvin

I use [Calamine ](https://github.com/tafia/calamine) with which I have an error that targets the encoding. Going from source file to source file I find : https://github.com/hsivonen/encoding_rs/blob/97acf71f69403ccd32dc64d45339aeb9ef7ba3b2/generate-encoding-data.py#L239 If I retrieve the sources...

thetopic

Add explicit `include` to `Cargo.toml`

5

I noticed that `encoding-rs` is the largest download in my crate graph at 1.4MB. While relatively it's not a lot, this could reduced significantly, by just adding a `include` to...

XAMPPRocky

Convert sorted data arrays to the Eytzinger order

3

The [Eytzinger order](https://arxiv.org/abs/1509.05053) improved things for Gecko's HTML parser. Data tables that are currently only searched by binary search should probably be converted to the Eytzinger order.

hsivonen

Potential Unsound: 1 out-of-bound read and 5 unaligned memory access.

7

Hello. I'm Yoshiki, a PhD student at CMU. We are testing a tool to automatically generate test cases from API data and existing tests. A few of our generated test...

YoshikiTakashima

Make encoding lists public

3

I recently migrated [Stringsext, a GNU Strings Alternative with Multi-Byte-Encoding Support](https://github.com/getreu/stringsext) from [rust-encoding](https://github.com/lifthrasiir/rust-encoding) to [encoding_rs](https://github.com/hsivonen/encoding_rs/). The Stringsext tool prints la list of supported encoding names. As the lists in `encoding_rs`...

getreu