hred icon indicating copy to clipboard operation
hred copied to clipboard

Alignment Question

Open sshleifer opened this issue 5 years ago • 0 comments

Thanks so much for this repo! In custom_collate_fn: (https://github.com/hsgodhia/hred/blob/master/util.py#L72) We

return u1_batch[sort1, :], u1_lens[sort1], u2_batch[sort2, :], u2_lens[sort2], u3_batch[sort3, :], u3_lens[sort3]

Doesn't this imply that our [d1,d2,d3] DialogTurns will not be aligned when we, somewhat later, call, qu_seq = torch.cat((o1, o2), 1)

(https://github.com/hsgodhia/hred/blob/master/modules.py#L39)

When do we unsort? Thanks!

sshleifer avatar Jul 25 '19 00:07 sshleifer