competitive-data-science icon indicating copy to clipboard operation
competitive-data-science copied to clipboard

Published 20 hours ago • verified publisher icon hse-aml

A bug in generating lag features

Open anhquan0412 opened this issue 7 years ago • 1 comments

There is a bug in week 4 programming assignment notebook where you generate lag features 'After creating a grid, we can calculate some features. We will use lags from [1, 2, 3, 4, 5, 12] months ago.'

The lag features are correct for only target_lag_{} (target_lag_1,2,3 ...) and incorrect for any other lag features.

I documented that bug and the fix in here. Fixing this bug helps me boost my score in LB tremendously. https://gist.github.com/anhquan0412/330494b051f74eacad3917f43e3ba43a

anhquan0412 avatar Feb 08 '18 17:02 anhquan0412

Great! Thank you for finding this out.

aguschin avatar Jun 13 '20 13:06 aguschin