competitive-data-science icon indicating copy to clipboard operation
competitive-data-science copied to clipboard

Mislabeling of section in compute_KNN_features

Open alecalma opened this issue 4 years ago • 0 comments

Hi,

in compute_KNN_features, honours assignment week 4, inside get_features_for_one, it says:

"2. Same label streak: the largest number N, such that N nearest neighbours have the same label."

I find the task label to be very misleading. Literally it means to check the max number of neighbours within the array with the same label. I would reformulate the task label as:

"2. Same label streak: the largest number N, such that the first N nearest neighbours have the same label."

I hope you can understand my point.

Thanks for the great course!

Alessandro

alecalma avatar Sep 03 '20 13:09 alecalma