Hector Sanjuan

Results 424 comments of Hector Sanjuan

Triage: * The example should be super concise and as short as possible. This is too verbose. We have helpers and wrappers that could have been used. Lots of flexibility...

If you point me to the right repos, I can put it on my to-do list

> We may need some form of "self dial" in the future for a libp2p I need it, now.. Happy if it is a non-default option.

We want to be able to dial our own peer ID.

I didn't implement [Raft](https://github.com/hashicorp/raft), we just plugged-in the libp2p transport. I haven't looked exactly why it tries to contact itself, but it does and produces a continues stream of errors...

@Stebalien not blocking me, but I'd like to address it rather sooner than later. I'm willing to take the stab if given a few pointers.

> 4. Make protocols supporting self-dialling declare so explicitly: > either when registering themselves by extending SetStreamHandler(pid protocol.ID, handler inet.StreamHandler) with an Option... arg. > by adding a method somewhere...

Triage: - @achingbrain will follow up

Triage: - @achingbrain will review

hmm yes for example: https://github.com/ipfs-cluster/ipfs-cluster/blob/master/rpc_api.go#L218-L220 Essentially you work with in/out channels...