Hector Sanjuan
Hector Sanjuan
> We should do blocking on the `blockstore.Blockstore` and `exchange.Exchange` API arguments before they are passed to the blockservice. What if it returns a blocking Exchange and blocking Blockstore when...
That sounds like relying on an implementation detail that causes exchange-blocking by chance (only because blockstore is checked first?) so I'm not very sold... better to wrap both. I think...
What about a new `SessionBlockstore` interface that has `NewSession` ?
> I think #35 is cleaner. It is, but relies on the fact that a specific blockservice implementation exists that provides content-blocking capabilities. > But you can't wrap this session...
Thanks! please give me a couple of days to look into the proposals.
In principle I'm ok with [#563](https://github.com/ipfs/boxo/pull/563#issuecomment-1892102724) in that it is aligned with how we normally do things... (granted this might not be the best way of doing things all the...
What is the motivation for embedding sessions in the context? I may have missed it but I didn't see what prompted that change in the first place.
I understand. Honestly, now that mostly everything is in *boxo*, it might be worth to streamline session handling one day. Passing things in context is a hack so that we...
I have a user with a large ipfs-cluster (>1000 peers) complaining of issues that are consistent with pubsub propagation failures and the issue happens in both go-libp2p-v0.33.2 + go-libp2p-pubsub v0.10.0...
> We're confident that we fixed _a_ issue, but there may be others. My initial thought was [#2764 (comment)](https://github.com/libp2p/go-libp2p/issues/2764#issuecomment-2050450383), but if that cluster uses QUIC it shouldn't be affected by...