poke-env icon indicating copy to clipboard operation
poke-env copied to clipboard

Probable typo in the OpenAI Gym wrapper example

Open DiTo97 opened this issue 3 years ago • 1 comments

I just read the docs for reinforcement learning purposes, and I think there may be a typo in the OpenAI Gym wrapper example at https://github.com/hsahovic/poke-env/blob/master/examples/rl_with_open_ai_gym_wrapper.py#L36, which is shown in the docs. If you want to account for the number of remaining Pokémons in both parties, shouldn't you filter for if not mon.fainted?

DiTo97 avatar Feb 25 '22 15:02 DiTo97

That's a good catch - thanks @DiTo97 !

hsahovic avatar May 08 '22 23:05 hsahovic