vue-pdf-embed icon indicating copy to clipboard operation
vue-pdf-embed copied to clipboard

Published 20 hours ago • verified publisher icon hrynko

supported svg

Open baixjian opened this issue 1 year ago • 7 comments

Thank you for producing such fascinating code, and I was thinking it would be great if this component supported svg

baixjian avatar Jun 14 '23 02:06 baixjian

Hi @baixjian,

Thanks for your feedback! What do you mean by SVG support?

hrynko avatar Jun 14 '23 10:06 hrynko

I'm sorry for not being clear enough. What I mean is whether the rendering mode of pdf can support canvas and svg

baixjian avatar Jun 26 '23 06:06 baixjian

Ah ok, got it now. I would consider this, but could you provide details on when it might be useful?

hrynko avatar Jun 26 '23 09:06 hrynko

Thank you for your reply. For example, in some mobile scenes, pdf needs to be scaled by hand. If it is canvas, the enlarged content will be a little fuzzy, but if it is rendered in svg mode, it will be very clear, which is my point.

baixjian avatar Jun 27 '23 01:06 baixjian

Ah ok, got it now. I would consider this, but could you provide details on when it might be useful?

Do you have a plan to support svg rendering mode, or do you think svg mode is necessary？Looking forward to your reply。

baixjian avatar Jul 20 '23 01:07 baixjian

Hi @baixjian,

I opened a PR introducing the SVG render mode (#162). However, I highly doubt it, since this renderer has many issues, and many sources do not recommend it at all. Could you please check if it does its job for you?

PS: If it's just about clarity when scaling, it can be adjusted using custom width, height, and scale props

hrynko avatar Sep 20 '23 09:09 hrynko

Hi @baixjian,

I opened a PR introducing the SVG render mode (#162). However, I highly doubt it, since this renderer has many issues, and many sources do not recommend it at all. Could you please check if it does its job for you?

PS: If it's just about clarity when scaling, it can be adjusted using custom width, height, and scale props

Thank you for your reply, I will read your code carefully

baixjian avatar Dec 07 '23 03:12 baixjian

See https://github.com/hrynko/vue-pdf-embed/pull/162#issuecomment-2141443268

hrynko avatar May 31 '24 08:05 hrynko