ppsspp Persona 2 Innocent Sin's UI lines don't work at all resolutions

When BR's off the stripes that make up the backgrounds of certain UI elements are being spaced out correctly. screen00098 When any form of BR is turned on however, the spacing gets messed up, causing certain stripes to be spaced further away from each other. screen00097

Aug 23 '13 00:08 internetakias

I noticed it too, but it seems like such a minor issue, considering that it does not affect the playability of the game one way or the other, as compared to the massive transparency issue it had previously which was resolved thanks to @hrydgard

Thanks for the report anyway, this one will take time to fix.

Aug 23 '13 00:08 bonquacks

Huh. Seems like on Android it's the complete opposite BR off: screenshot_2013-08-23-07-27-06 Br on: screenshot_2013-08-23-07-27-00

Aug 23 '13 04:08 internetakias

I think it may be related to scissor . I may be wrong . Is this tested with latest build ?

Aug 23 '13 06:08 dbz400

Yes, both my PC and Galaxy S3 are using the latest build

Aug 23 '13 06:08 internetakias

Can you a bit older version of it ? v0.9.1-15-g1ea0cd0 (which is before the scissor fix)

Aug 23 '13 06:08 dbz400

Not really seeing a difference PC: BR OFF screen00000 BR ON screen00001

ANDROID: BR OFF screenshot_2013-08-23-10-25-48 BR ON screenshot_2013-08-23-10-25-56

Aug 23 '13 07:08 internetakias

It is funny .They are exactly reversed among Android and PC version . Really not much idea what is real cause .....

Aug 23 '13 07:08 dbz400

Should I try attaching a framedump? Would it help any?

Aug 23 '13 07:08 internetakias

Btw , we can see the rendering of 'Normal' is also different even stripes are correct .

Aug 23 '13 07:08 dbz400

Here are the frame dumps ON: https://docs.google.com/file/d/0BzC2uL8lp2t-V0doa3Z4c0l3b0E/edit?usp=sharing OFF: https://docs.google.com/file/d/0BzC2uL8lp2t-NDZuUTgzRko1TlE/edit?usp=sharing

Aug 23 '13 08:08 internetakias

That would be helpful .Will check it out.

Aug 23 '13 16:08 dbz400

That would be helpful .Will check it out.

Aug 23 '13 16:08 dbz400

Alright .Just able to test it .Looks like bit different indeed.

Real PSP
PPSSPP

Aug 25 '13 09:08 dbz400

@internetakias , just wonder which version you are able to reproduce the difference between rendering mode ? as i cannot reproduce it .

Aug 25 '13 09:08 dbz400

v0.9.1-131-g2d89323 64 BIT

Aug 25 '13 10:08 internetakias

Just tested it out on the 32 bit build, and couldn't notice anything different.

Aug 25 '13 10:08 internetakias

Adventures To Go! (which is nowhere as good as a Persona game) also has the "too dark" issue.

-[Unknown]

Aug 25 '13 14:08 unknownbrackets

Humm i just tried v0.9.1-131-g2d89323 64 bit , also cannot see the difference .Strange.

Aug 25 '13 23:08 dbz400

Hmm... Maybe it has to do with the graphics card? I have an AMD Radeon HD 6770. Also, all modes of buffered rendering produce the same result, FYI.

Aug 26 '13 01:08 internetakias

However , can 131 build still able to produce the following correct one from your system ? afdbebfa-0bc5-11e3-8fdd-d81856dd1e6d

Aug 26 '13 08:08 dbz400

The lines seem okay on desktop, at least for me, but it's solid if render resolution is set to 2x.

How does this look for you now?

Software rendering looks pretty good now and is not too dark (with #5158.)

Dark issue is already covered by #3379.

-[Unknown]

Jan 20 '14 07:01 unknownbrackets

It looks fine on PC, haven't checked on my GS3 yet, though.

Jan 21 '14 09:01 internetakias

For me, this makes it look much more correct on all resolutions:

void FramebufferManager::SetLineWidth() {
#ifndef USING_GLES2
    glEnable(GL_LINE_SMOOTH);
    if (g_Config.iInternalResolution == 0) {
        glLineWidth(std::max(1.0f, (float)(PSP_CoreParameter().renderWidth / 480.0f)) + 0.5f);
        glPointSize(std::max(1.0f, (float)(PSP_CoreParameter().renderWidth / 480.0f)));
    } else {
        glLineWidth((float)g_Config.iInternalResolution + 0.5f);
        glPointSize((float)g_Config.iInternalResolution);
    }
#endif
}

Lines are pretty uncommon. I wonder if we should/can redo them as polygons to try to get the width more correct...

-[Unknown]

Jun 08 '14 18:06 unknownbrackets

We can, of course, the same way we deal with rectangles: Software transform them to screen space, then tesselate (make triangles) manually. I don't think it's very well defined what to do at corners of line strips though, the PSP doesn't care about the corner style because there are no more-than-one-pixel-wide lines on it.

Jun 08 '14 19:06 hrydgard

Just a heads up, it seems like this issue is present in the D3D9 backend now isd9

Sep 28 '14 13:09 internetakias

This is still present and behaves differently depending on the backend and rendering resolution. Win10, 64bit, v1.2.1-56-gcc4e7c4. AMD R9 270X, 16.2.1 driver.

OGL, 1xIR: ogl_1x_ulus10584_00008 OGL, 2xIR: ogl_2x_ulus10584_00009 D3D, 1xIR: d3d_1x_ulus10584_00010 D3D, 2xIR: d3d_2x_ulus10584_00011

Basically, it seems to be fine at 2x (and other multiples of 2) in OGL, and at 1x in D3D.

Mar 09 '16 13:03 trostboot

Same happens in Eternal Punishment: Screenshot_2020-03-19-16-54-47-70_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-03-19-16-55-33-24_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-03-19-18-21-39-76_2f85358b2198d26f8aca533d68bee793