ppsspp icon indicating copy to clipboard operation
ppsspp copied to clipboard

"Global volume" string is confusing

Open NABN00B opened this issue 1 year ago • 4 comments

The "Global volume" setting doesn't affect UI volume so it shouldn't be labeled as global, but rather "Game volume" or something.

On another note, the preview volume IS affected by the aforementioned setting, but I feel like this should be handled by a separate "UI volume" setting, which is something we don't have. See also #18865

NABN00B avatar Feb 24 '24 18:02 NABN00B

Not that it doesn't require changes, but a piece of history: this was called global volume, because it was needed for devices that doesn't have volume control and also, because in the past it had additional options for SAS and ATRAC/MP3 audio. They were called differently I guess something alike "music" and "effects" don't remember exactly, but since they weren't doing what they were called(which was just a common use, but all games are different), people were crying about the setting not affecting what they wanted and as such the additional options got removed.

It probably needs to be divided to:

  • In-game volume with a sub-option of reverb volume (both prefferably as game specific settings),
  • UI volume with a sub-option of achievements volume (through maybe those could just be normalized if the option exist purely because the achievements were too loud compared to other UI sounds) and possibly separate volume for preview songs.

And maybe have a global volume on top of them all to keep it simple if there are still devices lacking volume control.

Currently there's really no clear separation, just new things got new volume sliders without taking into account of what existed before and it got a bit messy.

LunaMoo avatar Feb 25 '24 10:02 LunaMoo

I understand the history and I've come pretty much to the same conclusion as you LunaMoo.

In addition there could also be a tick for Advanced volume settings as unknown described here https://github.com/hrydgard/ppsspp/issues/7376#issuecomment-172445981

NABN00B avatar Feb 25 '24 10:02 NABN00B

For devices like the steamdeck, where volume is controlled mainly by the OS. The PSP should be locked so it always uses the greatest range, but a UI volume slider and mute(to replace enable/disable) would be nice. So "game" volume should have a slider and a 3 position for max/adjusted/mute, perhaps just a slider with snap-to slots at the ends for these.

cheako avatar Feb 26 '24 18:02 cheako

Yeah, this indeeds needs cleanup, along the lines of LunaMoo's proposal

hrydgard avatar Feb 27 '24 04:02 hrydgard