ppsspp icon indicating copy to clipboard operation
ppsspp copied to clipboard

Published 20 hours ago • verified publisher icon hrydgard

Add GamedataInstall of osm

Open sum2012 opened this issue 3 years ago • 14 comments

fix #14688 1

sum2012 avatar Sep 17 '22 13:09 sum2012

I do not know that how to solve Build / build (ubuntu-latest, test, clang, clang++, ./b.sh --headless --unittest, clang-normal) build fail PSPGamedataInstallDialog.cpp:(.text+0x13f0): undefined reference to `osm'

sum2012 avatar Sep 17 '22 13:09 sum2012

Most games show progress bars during install. Is this to workaround some specific game that doesn't? Or a bug in PPSSPP that's preventing the progress bar in that game?

-[Unknown]

unknownbrackets avatar Sep 17 '22 19:09 unknownbrackets

workaround for Everybody's tennis and Hot Shots Tennis: Get a Grip

sum2012 avatar Sep 17 '22 23:09 sum2012

Hm, I think we can do better with some PPGe graphics. What's shown on the real PSP during install?

hrydgard avatar Sep 18 '22 08:09 hrydgard

@hrydgard this picture change to english,better pic_0000 pic_0003 pic_0004

sum2012 avatar Sep 18 '22 10:09 sum2012

Thanks, yeah, I think we should try to approximate that instead. Should be fairly easy, I might take a look in a while.

hrydgard avatar Sep 18 '22 11:09 hrydgard

There must be a flag, some games show their own UI. I think Valkyria Chronicles 2, for example.

-[Unknown]

unknownbrackets avatar Sep 18 '22 13:09 unknownbrackets

There must be a flag, some games show their own UI. I think Valkyria Chronicles 2, for example.

-[Unknown]

Valkyria Chronicles 2 use SceUtilitySavedata instead of sceUtilityGamedataInstall

sum2012 avatar Sep 18 '22 21:09 sum2012

Hm, maybe it does. At least its sequel uses it:

Valkyria Chronicles 3 progress

It's been a while but I don't think it shows any PSP OS UI. It has the whole nice "sketch becoming a colored in image" thing instead.

-[Unknown]

unknownbrackets avatar Sep 18 '22 23:09 unknownbrackets

It wouldn't be a complete disaster if we drew an extra progress bar on top though, in case we can't find the flag...

hrydgard avatar Sep 18 '22 23:09 hrydgard

@unknownbrackets I don't know that my game of Valkyria Chronicles 2 don't have gameinstall log: 1

full log: https://gist.github.com/sum2012/9e9f8dc8bb56583a576faccdafafd53f

sum2012 avatar Sep 19 '22 11:09 sum2012

Sorry I meant its sequel, Valkyria Chronicles 3 / Senjou no Valkyria 3.

-[Unknown]

unknownbrackets avatar Sep 19 '22 13:09 unknownbrackets

A small note: jpcsp imp game install screen (missing Install completed.) in https://github.com/jpcsp/jpcsp/commit/7227a2df1f9c1e487576369e57a48d8aeb4d7eda 1 2

sum2012 avatar Sep 25 '22 12:09 sum2012

Install completed. added in https://github.com/jpcsp/jpcsp/commit/09c9374b9e12109689120795c859a94828a14a91 edit:easier to port the source : https://github.com/jpcsp/jpcsp/compare/c36e0026b5e3d9ab86fc84353bde748024ac3b21..09c9374b9e12109689120795c859a94828a14a91

3

sum2012 avatar Sep 27 '22 22:09 sum2012

So the flag about whether to show the dialog or not seems to be SceUtilityGamedataInstallParam.mode == PSP_UTILITY_GAMEDATA_MODE_SHOW_PROGRESS, and the constant is just 1. Easy enough.

I think a first version of this could just check that flag and draw a progress bar, and skip the confirmation and stuff.

hrydgard avatar Jan 12 '23 09:01 hrydgard

Closing this because I merged #17919

hrydgard avatar Aug 18 '23 14:08 hrydgard