ppsspp icon indicating copy to clipboard operation
ppsspp copied to clipboard
verified publisher icon hrydgard

Remaining rendering problems in Tantalus games

Open hrydgard opened this issue 3 years ago • 12 comments

Now that the main issues of #15898 have been fixed in #15907, Cars and the MX vs ATV games are playable and render okay at 1x. Spongebob is near perfect, the depth swizzle just needs improvement for higher resolution to get sharp edges against the sky.

There are still issues though:

  • In games other than Spongebob, the sky seems 1 pixel off even in 1x, leading to some weird fringes: image
  • Vertical stripes at 2x or higher resolutions image
  • Performance improvments are possible - we're not always making good use of load/store on renderpasses, and reinterpret can often be limited to smaller rectangles, at least in theory.

hrydgard avatar Aug 28 '22 07:08 hrydgard

MX vs. ATV Reflex still has a issue: Screenshot (38)

Panderner avatar Aug 28 '22 09:08 Panderner

Which api and hardware?

hrydgard avatar Aug 28 '22 10:08 hrydgard

Vulkan and OpenGL. MX vs ATV Untamed X2 Reso. Screenshot_2022-08-28-18-22-39-231_org ppsspp ppsspp

Vulkan/OpenGL SpongeBob SquarePants. Screenshot_2022-08-28-18-22-13-990_org ppsspp ppsspp

Software is glitchy Screenshot_2022-08-28-18-21-50-654_org ppsspp ppsspp

BTW thanks for improving this long standing issue.

ghost avatar Aug 28 '22 10:08 ghost

There's a bug in hack setting lower resolution for effects for MX vs ATV Untamed. Screenshot_2022-08-28-18-28-04-386_org ppsspp ppsspp

ghost avatar Aug 28 '22 10:08 ghost

Here's a screenshots using Direct3d 9: Screenshot (39) Screenshot (40) Screenshot (41)

Panderner avatar Aug 28 '22 10:08 Panderner

c75b023 fixes the problem you reported in MX vs ATV @Panderner .

hrydgard avatar Aug 28 '22 13:08 hrydgard

Car's O Rama and MX vs ATV graphics is broken again.

Screenshot_2022-09-14-12-46-31-97 Screenshot_2022-09-14-12-46-55-44

ppsspp v1.13.2-947 x1 Resolution both happen in opengl and vulkan.

ghost avatar Sep 14 '22 04:09 ghost

Thanks, I'll fix it up.

somehow, the culprit is https://github.com/hrydgard/ppsspp/commit/39890f7d6fea27be6c748e0182f9997df323331f

hrydgard avatar Sep 14 '22 06:09 hrydgard

OK, fixed it up, back to the way it was.

hrydgard avatar Sep 14 '22 06:09 hrydgard

Car's O Rama is darker now unlike before.Tested both opengl and vulkan backend.

Recently ppsspp build. Screenshot_2022-10-11-16-52-02-43

Your screenshot above. 187034888-676beabc-62e1-400b-a8fc-f5f76eac6b96

ghost avatar Oct 11 '22 08:10 ghost

Interesting, I'll have to look into that.

hrydgard avatar Oct 11 '22 09:10 hrydgard

And also MX vs. ATV Reflex: ULUS10429_00001

Panderner avatar Oct 11 '22 15:10 Panderner

Tested in latest build, Vulkan backend. Confirmed games are darker than before:

image

ppmeis avatar Dec 17 '22 11:12 ppmeis

Hm, that's not expected. I'll try to look at it, but might not be until after 1.14.1, which I'll launch on Monday or Tuesday.

Seems to be some kind of automatic brightness adaptation, that didn't work before, and now malfunctions, heh.

hrydgard avatar Dec 17 '22 14:12 hrydgard

Went ahead and did a bisect, the darkening behavior (it gradually darkens as you start the track) started in 92eaac0210ffdc1f3b9bcd8af5599957556e4a20 , which also fixed some rather bad rendering issues.

So presumably there's a brightness adaptation effect that started working at that commit, but is not working completely correctly. Sigh, might be a tricky one.

hrydgard avatar Jan 25 '23 22:01 hrydgard