ppsspp Graphic issues in Syphon Filter Dark Mirror and Logan's Shadow

trafficstars

I'm not refering to #10229

What happens ?

SFX like fire, flames and smoke don't display correctly. This YT video is from 2017 and not from me but it's still present in 1.10.3. Currently tried on my PC (W10 pro, i7 4790k, GTX 970) with every backend and tried ticking and unticking various performance hacks (thought it could be related to HW transform like https://github.com/hrydgard/ppsspp/issues/7306 but nope).

How it looks now (note the explosion and the flames after) :

https://youtu.be/3xpdzI7K0wA?t=40

How it should look :

https://youtu.be/h2Jg1BEIg7M?t=14

Oct 21 '20 21:10 Kayael76

Can you generate and upload a GE frame dump? See instructions here: https://github.com/hrydgard/ppsspp/wiki/How-to-create-a-frame-dump

Oct 21 '20 21:10 hrydgard

Sure, there you go :

recording.zip

Hope it worked correctly !

Oct 22 '20 00:10 Kayael76

Thanks, it replays just fine! Unfortunately the problem was not as simple as I had hoped - I thought it might have been the mipmap blending trick seen in #6537, but it's doing just plain drawing with no fancy tricks, indicating that this is actually likely a CPU emulation bug :(

Oct 22 '20 07:10 hrydgard

Also affects Resistance seems like its the same engine

Nov 02 '20 11:11 ghost

If I have time, I would try to make more exist value of the following table in Core/MIPS/MIPSVFPUUtils.cpp to test whether effect this game.

Nov 25 '20 15:11 sum2012

Anyone with windows 64 bit Please test this build https://drive.google.com/file/d/1QOySqRLZmQwrHQQWNa_aOKgupUPGebDu/view?usp=sharing This change: https://github.com/hrydgard/ppsspp/commit/3592a0f8ea86f06a6edeec558e10d31d9cb70098 Based on this table https://www.mathcelebrity.com/anglebasic.php?entry=210&coff=&pl=sin

Dec 04 '20 15:12 sum2012

Those are probably not gonna do much and are unfortunately wrong - remember, angle here is not a normal radians angle that goes from 0 to 2*PI, it goes from 0 to 4 for the full circle.

Dec 04 '20 15:12 hrydgard

I gave it a try but no, it doesn't work as intended. Thanks for trying though !

Dec 04 '20 19:12 Kayael76

@hrydgard ok

Dec 04 '20 22:12 sum2012

Can anyone try again with windows 64 bit ? https://drive.google.com/file/d/1O7EoOxVH5L_kCVLgsqvm3KiFu22dZIFh/view?usp=sharing This apply special angle and double precision

Dec 05 '20 13:12 sum2012

I tried but no changes unfortunately.

Dec 05 '20 15:12 Kayael76

Maybe related to #10165