Graphical glitches related to save states and minimizing

[Panderner]

Here's what's happens a glitches when the black screen effect bug but when i use the save state it changes the screen to Save State's thumbnail.

Here's a Example for enemy encounter effect in Persona 2: Innocent Sin:

Here's what's looks like without using save states or minimizing:

and here's a another one using save states or minimizing:

Here's a shatter effect in Danganronpa comparison:

With using save states or minimizing:

Without using save states or minimizing:

and what save screen screen and pause screen looks like:

YS Seven:

[Panderner]

Games affected: Persona 1 and 2 enemy encounter effect Shatter effects, save screens, pause screen in Danganronpa. YS Seven Danball Senki and Danball Senki Boost (#13338) Gundam AGE Universe Accel/Comsic drive (only happens for block transfer effects turned off) Gundam Battle Series (#13749) Hot Shots Shorties (Everybody's Stress Buster) Portable Island screenshots (#14533)

Games affected for graphical artifacts: Sega Rally (#6979) Juiced 2 (#7295) Colin McRae Rally 2005 (#7810) flickering shadows

[Panderner]

Danball Senki and Danball Senki Boost affected this issue:

[Panderner]

I've mentioned #8708, #13079 and #13338 for using these screenshots that are affected this bug that changes pictures using save states and minimizing

[hrydgard]

Thanks for the good reports, this is very weird...

[Panderner]

Character Talking backgrounds in Gundam AGE Universe Accel and Cosmic Drive (only happens if you disable simulate block transfer effects)

[hrydgard]

Stuff that only happens if you disable block transfers is not really bugs.

We're nearing a state now I think where we can just remove that option, it's not that many games that benefit without breaking anymore..

[Panderner]

Stuff that only happens if you disable block transfers is not really bugs.

even I've enabled simulate block transfer effects for Persona 2, enemy encounter effect glitch still happens. including other games like Danganronpa.

[hrydgard]

Then that's a real bug.

[Panderner]

This bug does not occur on Software Renderer mode.

[Panderner]

These issues are caused by graphical glitches related to framebuffers.

[Panderner]

@hrydgard this also happens on all backends.

[Panderner]

@hrydgard it also happens in all backends can you remove the OpenGL label?

[Panderner]

Regarding this comment https://github.com/hrydgard/ppsspp/issues/13256#issuecomment-691658682 Hot Shots Shorties (Everybody's Stress Buster) it also affected this issue:

Before Minimizing:

After Minimizing:

[hrydgard]

Has this worked in old builds? Possibly back when we had Readback mode in addition to buffered and non-buffered?

At least the Persona 2 issue seems to be texturing from a section of RAM, so this seems to be about the CPU reading back the screen copying it from VRAM to RAM. If you switch tasks or save state, we readback and write the framebuffer to VRAM, which makes it look like it works (kind of - it's still an old frame).

So likely there's a function that needs patching (or we need to implement proper detection of CPU reading from VRAM, which is difficult).

Anyway, postponing to 1.12.

[Panderner]

Same happens for older versions of PPSSPP

[Panderner]

Here's what happens when i disable BlockTransferAllowCreateFB for Ys Seven

BlockTransferAllowCreateFB off:

BlockTransferAllowCreateFB on:

[LunaMoo]

So the compat hack should be disabled for this title, since it causes issues. It was already written, so just going to paste why rushing to add games to compat (speed)hacks was(is) a bad idea: https://github.com/hrydgard/ppsspp/issues/11669#issuecomment-470393342

[hrydgard]

Thanks for narrowing that down @LunaMoo . I think we'll just disable this speedhack for Ys like you did in your fork.

[ghost]

Here's what happens when i disable BlockTransferAllowCreateFB for Ys Seven

BlockTransferAllowCreateFB off:

BlockTransferAllowCreateFB on:

@hrydgard please re-enable again BlockTransferAllowCreateFB on this game YS7.

To avoid glitch Panderner reproduce add this game also to ClearToRAM 👍 tried and tested.

[Panderner]

Enabling again for Ys Seven is bad idea @Gamemulatorer because it will result black screen save icons and BlockTransferAllowCreateFB off gif is a correct one.

Here's a gif for both: BlockTransferAllowCreateFB and ClearToRAM enabled:

[ghost]

Enabling again for Ys Seven is bad idea @Gamemulatorer because it will result black screen save icons and BlockTransferAllowCreateFB off gif is a correct one.

My save state png still correct.

[ghost]

Here's a gif for both: BlockTransferAllowCreateFB and ClearToRAM enabled:

Can you explain what's wrong in this gif?

[Panderner]

Here's a gif for both: BlockTransferAllowCreateFB and ClearToRAM enabled:

Can you explain what's wrong in this gif?

This gif is incorrect.

And this one is correct:

[ghost]

Here's a gif for both: BlockTransferAllowCreateFB and ClearToRAM enabled:

Can you explain what's wrong in this gif?

This gif is incorrect.

And this one is correct:

Can you explain more on details I didn't get what's wrong and correct o_0

Please elaborate more.

[Panderner]

As I mentioned in #13975 enabling BlockTransferAllowCreateFB for this game might cause save icons that draw black screen.

[ghost]

As I mentioned in #13975 enabling BlockTransferAllowCreateFB for this game might cause save icons that draw black screen.

Well as you can see my savestate icon still correct maybe this is adreno gpu bug?

[Panderner]

Here's a gif using software rendering:

[ghost]

My save icon png still correct

[ghost]

Here's a gif using software rendering:

Please explain more on details I didn't get your problem with this :/

[Panderner]

My save icon png still correct

Look at in-game save screen: