ppsspp icon indicating copy to clipboard operation
ppsspp copied to clipboard

Tom Clancy's Splinter Cell - Essentials (USA) Load status issue

Open sum2012 opened this issue 5 years ago • 5 comments

(Separate issue from #13035 Save status in-game, Re-run ppssspp Load game,load save status boom (v1.10) 1

sum2012 avatar Jun 27 '20 13:06 sum2012

This is a very bad issue , load state freeze , graphical glitch :'(

fahadrashid7705 avatar Jul 02 '20 17:07 fahadrashid7705

I cannot reproduce this in v1.11.3 but I can reproduce this again in v1.12.2-9 see ~ https://github.com/hrydgard/ppsspp/issues/15020

edit: can still reproduce since the oldest version.

ghost avatar Oct 15 '21 02:10 ghost

If you can go to 0881c21c in the debugger or web debugger, and show the code around that address, it might be helpful. I'm wondering if it's an HLE call or a direct memory access.

-[Unknown]

unknownbrackets avatar Oct 17 '21 05:10 unknownbrackets

Still hang on the latest build IDK if this log is useful

<<< log_count = 1 >>>
[10-20 22:29:30.235 17805:17805 F/DEBUG]
pid: 15688, tid: 17732, name: Thread-47  >>> org.ppsspp.ppsspp <<<

ghost avatar Oct 20 '21 14:10 ghost

This might be related to this https://github.com/hrydgard/ppsspp/issues/7244?

ghost avatar Aug 06 '22 09:08 ghost

v1.13.2-1044-g4b165f9fc blue screen 1 2

@hrydgard @unknownbrackets does we have Jit Invalidation in save and load states ?

sum2012 avatar Sep 20 '22 13:09 sum2012

I try to use "Interpreter" in save and load still same result

sum2012 avatar Sep 20 '22 13:09 sum2012

We do have jit invalidation in load/save state. I'm still interested in the code around 0881c21c.

-[Unknown]

unknownbrackets avatar Sep 20 '22 13:09 unknownbrackets

This is after load status 1

sum2012 avatar Sep 20 '22 21:09 sum2012

I wonder if what's happening is, the game copies some RAM that had executed, and it "happens" to work because the replacement/hack still works. But then save/load state don't clear THAT replacement, because it's unknown to PPSSPP.

If you go to the memory viewer, what does it show for "allocation" and "write" under that address? It'll show a label in the status bar when you click the address, indicating what last allocated of wrote that address.

Anyway, it may also be something earlier and there may be nothing wrong with this replacement. If it says it's from the ELF, it's fine.

-[Unknown]

unknownbrackets avatar Sep 20 '22 22:09 unknownbrackets

In "allocation" show ELF,in "write" show ELFload 1 2

sum2012 avatar Sep 20 '22 22:09 sum2012

It's also a bit odd seeing a replacement in a delay slot...

If you set FunctionReplacements = False in ppsspp.ini, does that make save states load fine? Not sure if we could have a bad func detection, maybe? It doesn't seem to have given the function a name.

That said, if it is being detected correctly, it might just be a symptom from somewhere else.

-[Unknown]

unknownbrackets avatar Sep 20 '22 23:09 unknownbrackets

Load in FunctionReplacements = True of save states or make a new save states ( FunctionReplacements = False) then load states seem no problem now

sum2012 avatar Sep 21 '22 12:09 sum2012

@unknownbrackets Can we work around this ? After press load status -> reset game -> force FunctionReplacements = False ->Real load status -> force FunctionReplacements = True ?

sum2012 avatar Sep 22 '22 12:09 sum2012