ppsspp icon indicating copy to clipboard operation
ppsspp copied to clipboard

[Vulkan] Project Diva 2nd - Missing graphics (depth issue)

Open Leopard20 opened this issue 6 years ago • 20 comments

~This is possibly another Adreno 5xx driver bug.~ Vulkan: Screenshot_2019-09-01-12-09-19-232_org ppsspp ppsspp

OGL: Screenshot_2019-09-01-12-09-38-590_org ppsspp ppsspp

Frame dump: recording (1).zip

Leopard20 avatar Sep 01 '19 07:09 Leopard20

This occurs even on desktop. It appears to be caused by draw 686/1893 (a src >= dst test.) It draws correctly if that is skipped.

Depth clamp is enabled. Verts (triangle strip):

  • -2184.754639, -25494.019531, 565026.812500
  • 2448.613770, -20518.970703, 455450.062500
  • 2111.076416, -81579.367188, -436066.343750
  • -2356.259521, -100212.601563, -535462.250000

It's using a standard viewport/offset, so each of these points is outside the frustrum in some way (by virtue of Y alone.) However, since the depth is also outside, clipping is happening.

That being said, all vertices have negative Y, so both triangles should be cleanly outside the viewport no matter what.

-[Unknown]

unknownbrackets avatar Sep 01 '19 17:09 unknownbrackets

That is really bizarre, I don't see how that's possible...

hrydgard avatar Sep 01 '19 18:09 hrydgard

As much as i know Vulkan in PowerVR too is not so optimized for some games.I was facing many issues on my old phone and this new one running PowerVR Rogue Ge8320

ghost avatar Sep 02 '19 06:09 ghost

It this GE dump same happens in latest builds. The graphics works ok for rest of PVs. Screenshot_2021-01-16-17-25-19-358_org ppsspp ppsspp

But with this part in magnet PV the graphical glitch triggers here. Screenshot_2021-01-16-17-31-23-695_org ppsspp ppsspp

Panderner avatar Jan 16 '21 09:01 Panderner

This should be fixed with the latest depth clamp changes, I think. Sorry, forgot to link it.

That said, it's only on devices that support user clip/cull, which I think excludes Mali.

-[Unknown]

unknownbrackets avatar Dec 28 '21 22:12 unknownbrackets

~This is possibly another Adreno 5xx driver bug.~ Vulkan: Screenshot_2019-09-01-12-09-19-232_org ppsspp ppsspp

OGL: Screenshot_2019-09-01-12-09-38-590_org ppsspp ppsspp

Frame dump: recording (1).zip

Cannot reproduce this issue using the dump. Screenshot_2022-09-21-17-37-31-28 Adreno 506 GPU Vulkan ppsspp https://github.com/hrydgard/ppsspp/commit/3ff400e40e122dcba771d32b8a064a3b42e7e371

ghost avatar Sep 21 '22 09:09 ghost

Cool, maybe we can close then. Or quite likely, this might not be fully fixed on Mali yet...

hrydgard avatar Sep 21 '22 10:09 hrydgard

This was a negative Z issue, like the others it's fixed on devices with clip/cull distance support.

We could probably close most of them and leave a single issue open noting Mali. But retesting them with Adreno devices is not going to help. I already validated it in 2021 when I posted that this was fixed by the depth clamp changes.

-[Unknown]

unknownbrackets avatar Sep 21 '22 13:09 unknownbrackets

I cannot also reproduce this in my redmi 4x v1.18.1-1955-ga85f748677 Release CPU: Qualcomm Technologies, Inc MSM89 ABI: arm64 Page Size: 4096 bytes RW/RX exclusive: No Board: QC_Reference_Phone 3D API: Vulkan API version: 1.0.0 Device API version: 1.0.31 Vendor: Qualcomm VendorString: Adreno (TM) 505 Driver: 55.277.3829 (0dd15ef5) Depth buffer format: D24_S8 Refresh rate: 60.00 Hz

Image

ghost avatar May 22 '25 06:05 ghost

Your Redmi has an Adreno though, while above it seems the problems are mainly on Mali.

However, since we haven't gotten any more reports, I'll close this.

hrydgard avatar May 22 '25 07:05 hrydgard

Looks good on my phone with MALI GPU v1.18.1-1955-ga85f748677 Release CPU: MT6769Z ABI: arm64 OS: Xiaomi:M2003J15SC Page Size: 4096 bytes RW/RX exclusive: No Board: merlin 3D API: Vulkan API version: 1.1.0 Device API version: 1.1.131 Vendor: ARM VendorString: Mali-G52 Driver: 26.0.0 (06800000) Depth buffer format: D24_S8 Refresh rate: 60.00 Hz

Image

Unknowncat1991 avatar May 22 '25 07:05 Unknowncat1991

Looks good on my phone with MALI GPU v1.18.1-1955-ga85f748677 Release CPU: MT6769Z ABI: arm64 OS: Xiaomi:M2003J15SC Page Size: 4096 bytes RW/RX exclusive: No Board: merlin 3D API: Vulkan API version: 1.1.0 Device API version: 1.1.131 Vendor: ARM VendorString: Mali-G52 Driver: 26.0.0 (06800000) Depth buffer format: D24_S8 Refresh rate: 60.00 Hz

Image

Nope. Still happens for my Samsung Galaxy A35 using Vulkan.

Image

Panderner avatar May 22 '25 08:05 Panderner

Thanks @Panderner , reopening.

hrydgard avatar May 22 '25 11:05 hrydgard

Looks good on my phone with MALI GPU v1.18.1-1955-ga85f748677 Release CPU: MT6769Z ABI: arm64 OS: Xiaomi:M2003J15SC Page Size: 4096 bytes RW/RX exclusive: No Board: merlin 3D API: Vulkan API version: 1.1.0 Device API version: 1.1.131 Vendor: ARM VendorString: Mali-G52 Driver: 26.0.0 (06800000) Depth buffer format: D24_S8 Refresh rate: 60.00 Hz Image

Nope. Still happens for my Samsung Galaxy A35 using Vulkan.

Image

Does geometry shader or disable hw transform doesn't help this issues?

ghost avatar May 22 '25 12:05 ghost

Can you upload new ge frame dump @Panderner

Unknowncat1991 avatar May 22 '25 13:05 Unknowncat1991

Here:

ULJM05681.ppdmp.zip

For some reason, Enabling geometry shader culling fixes this.

Image

Panderner avatar May 22 '25 14:05 Panderner

This similar to issue https://github.com/hrydgard/ppsspp/issues/20104

Unknowncat1991 avatar May 22 '25 15:05 Unknowncat1991

My Huawei Nova 3i which doesn't support geometry shader culling can't reproduce this issues.

Image

Unknowncat1991 avatar May 26 '25 01:05 Unknowncat1991

My Huawei Nova 3i which doesn't support geometry shader culling can't reproduce this issues.

Image

Have you tried default settings to reproduce this issue and disabling geometry shader culling makes the difference?

Panderner avatar May 26 '25 04:05 Panderner

My Huawei Nova 3i which doesn't support geometry shader culling can't reproduce this issues. Image

Have you tried default settings to reproduce this issue and disabling geometry shader culling makes the difference?

Nova 3i does not have a geometry shader culling option and yes I was default settings when I test your ge frame dump.

Unknowncat1991 avatar May 28 '25 00:05 Unknowncat1991