ppsspp icon indicating copy to clipboard operation
ppsspp copied to clipboard

Earth Saver Plus - Inseki Bakuha Daisakusen (Japan) (PSN) text problem

Open benderscruffy opened this issue 7 years ago • 42 comments

PPSSPP v1.5.4-993-gab65c5210 Windows 64 bit during the game the text is way to big to fit in the screen i am using my own fonts off my own psp here is a screen from jpcsp jpcsp screen here it is from ppsspp ppsspp screen ppsspplog.zip

benderscruffy avatar May 20 '18 08:05 benderscruffy

Is this a duplicate of #2788? Does using fonts from the PSP official firmware fix the problem?

-[Unknown]

unknownbrackets avatar May 20 '18 21:05 unknownbrackets

i am using the fonts from the official firmware i dont use ppsspp fonts

benderscruffy avatar May 20 '18 22:05 benderscruffy

v1.7.1-210-g9bda7cb64 still happens

benderscruffy avatar Nov 28 '18 04:11 benderscruffy

one other thing i noticed is during gameplay there is black lines happens in both DX11 and opengl earth1 DUMP.ZIP

benderscruffy avatar Nov 28 '18 04:11 benderscruffy

Snake Warriors - Training (USA) (minis) (PSN) has the same problem snake

benderscruffy avatar Dec 27 '19 23:12 benderscruffy

Loading module sceFont_Library with version 0101, devkit 06020010

sceFontNewLib(088a8660, 09ffdea0) sceFontGetNumFontList(0993a7ac, 09ffdea0) sceFontGetFontList(0993a7ac, 09ffdea4, 18) sceFontFindOptimumFont(0993a7ac, 09ffebc4, 09ffdea0) sceFontOpen(993a7ac, 0, 0, 9ffdea0) sceFontGetFontInfo(993a7f8, 9ffec6c) sceFontClose(993a7f8) sceFontDoneLib(0993a7ac)

sceFontNewLib(088a8660, 09ffd6d0) sceFontGetNumFontList(09c8718c, 09ffd6d0) sceFontGetFontList(09c8718c, 09ffd6d4, 18) sceFontFindOptimumFont(09c8718c, 09ffe3f4, 09ffd6d0) sceFontOpen(9c8718c, 0, 0, 9ffd6d0) sceFontGetFontInfo(9c871d8, 9ffe49c) sceFontGetCharInfo(09c871d8, 12508, 09ffe5a4) sceFontGetCharGlyphImage(9c871d8, 30dc, 9ffe5e0) sceFontGetCharInfo(09c871d8, 12479, 09ffe5a4) ... sceFontClose(9c871d8) sceFontDoneLib(09c8718c)

It follows this pattern a lot in the log. That's either jpn0.pgf, or if zh_gb.pgf exists, zh_gb.pgf.

But interestingly, the JPCSP font appears to be a serif font. So it seems like maybe an issue in sceFontFindOptimumFont?

-[Unknown]

unknownbrackets avatar Jan 01 '20 16:01 unknownbrackets

This how it looks without a real PSP font: Screenshot_2020-03-31-12-48-46-06_2f85358b2198d26f8aca533d68bee793

Panderner avatar Mar 31 '20 04:03 Panderner

A screenshot from a PSP would help - especially to confirm which font it should be.

-[Unknown]

unknownbrackets avatar Mar 31 '20 04:03 unknownbrackets

There are no YouTube videos for this game except the developer of this uploads the preview but it's only 6 videos. (3 on the DSiWare, 3 on the PSP) Unfortunately I don't have a PSP.

Panderner avatar Mar 31 '20 14:03 Panderner

@unknownbrackets @Panderner @benderscruffy

This screen shot is screen of Real PSP. When it's helpful, I'm happy.

HUD-FINAL_shot001

nassau-tk avatar Aug 23 '20 03:08 nassau-tk

@unknownbrackets @benderscruffy @Panderner

I tested v1.10.3-700 that Installed All of Real PSP Font. But It's not loading English font file corectly I think. earthsaver_font01

nassau-tk avatar Sep 17 '20 11:09 nassau-tk

@unknownbrackets

I wonder this strange point.

This game loading "jpn0.pgf" on my case. Because,I have PSP-2000(Japan). So,I don't have "zh_gb.pgf".

Real PSP is not "Gothic Font" in the right side text of game.(I don't know how to say these Font style.)

But,"Real PSP Font installed PPSSPP" is indicated by "Gothic font" and "Non-Italic Style".

Why,PPSSPP change the Font Style? Real PSP or PPSSPP has font shape transform system?

EDIT:"Non-Gothic" Is it called "Antique Style"?

nassau-tk avatar Oct 10 '20 01:10 nassau-tk

Maybe, "ltn11.pgf" or "ltn15.pgf" must loading.

For reference #9466 my report of ltn[x].pgf.

nassau-tk avatar Oct 15 '20 17:10 nassau-tk

IMG_20201016_064012 The right side uses ltn15.pgf used for PSP. this is caused by a glitch it's uses jpn0.pgf for PPSSPP. When i replace jpn0.pgf to ltn15.pgf renamed to jpn0.pgf it happened.

Panderner avatar Oct 15 '20 22:10 Panderner

Yes,Right. it's tested me too.

  1. If there is jpn0.pgf in Font folder then ltn15.pgf is not loading.
  2. If there is not jpn0.pgf in Font folder then ltn15.pgf is loading. However,ltn15.pgf has not Japanese characters. So,Japanese characters not appear.

Real PSP is loading these font data separate. But,PPSSPP can't doing it.

I tested elase the Alphabet characters from jpn0.pgf (Custom Font data). ltn15.pgf is Real PSP data. Result is below. inseki_NoABFontjpn0

If Font data has not these characters then it not load from other Font data.

Maybe, This issue will solved by load jpn0.pgf & ltn15.pgf at same timing.

@unknownbrackets said

It follows this pattern a lot in the log.

Is it include load ltn15.pgf???

nassau-tk avatar Oct 16 '20 01:10 nassau-tk

This issue is not solved by PSP original & new PPSSPP PGF font.(v1.10.3-1306) I think that the problem is in PGF loading task. But,Other games could loading individual fonts like a "Boxer's Road 2 The Real".

nassau-tk avatar Dec 09 '20 04:12 nassau-tk

@sum2012

Suddenly, Excuse me. I'm thinking that you have a lot of knowledge for JPCSP. (Is it Right?)

So, If you get feel interesting for this issue I'm happy.

(This issue still happen on v1.10.3-1552.)

Note : Of course, The issue priority is not High!

nassau-tk avatar Jan 12 '21 07:01 nassau-tk

edit:If old jpcsp version also have this problem ,then we might have solution to solve

在 2021年1月12日週二 下午3:23,nassau-tk [email protected] 寫道:

@sum2012 https://github.com/sum2012

Suddenly, Excuse me. I'm thinking that you have a lot of knowledge for JPCSP. (Is it Right?)

So, If you get feel interesting for this issue I'm happy.

(This issue still happen on v1.10.3-1552.)

Note : Of course, The issue priority is not High!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hrydgard/ppsspp/issues/11055#issuecomment-758461503, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQTT7AA2NC6FJJALD3VEBLSZP2FTANCNFSM4FAYAM2Q .

sum2012 avatar Jan 12 '21 10:01 sum2012

Did you feel interest a little? :smile: Thanks!

nassau-tk avatar Jan 12 '21 15:01 nassau-tk

Sorry,I forget to test this today. But I get a good start from jpcsp. I find bad font in 1880d18 version 2

sum2012 avatar Jan 17 '21 14:01 sum2012

I find that jpcsp need real psp font for this game

sum2012 avatar Jan 17 '21 15:01 sum2012

I'm guessing this might be a bug in the find optimum font logic, as noted in https://github.com/hrydgard/ppsspp/issues/11055#issuecomment-570066108. We probably need to create a test that uses its same parameters and figure out why we pick the wrong font.

-[Unknown]

unknownbrackets avatar Jan 17 '21 16:01 unknownbrackets

I find that use ppsspp 's font also fix jpcsp. So that @unknownbrackets said right " this might be a bug in the find optimum font logic, "

sum2012 avatar Jan 17 '21 22:01 sum2012

Great work!

nassau-tk avatar Jan 17 '21 22:01 nassau-tk

The jpcsp source of sceFontFindOptimumFont is in https://github.com/jpcsp/jpcsp/blob/master/src/jpcsp/HLE/modules/sceFont.java#L1154

Jpcsp logic: First find same fontStyle , No font found for the given style, try to find a font without the given font style (bold, italic...) No font found for the given style, try to find a font without the given font size. No font found for the given style, try to find a font without the given country.

sum2012 avatar Jan 18 '21 13:01 sum2012

@sum2012

Please tell me about Jpcsp. "If install our current PGF font to Jpcsp then the text will appear correctly." Did you said mean above?

nassau-tk avatar Jan 18 '21 14:01 nassau-tk

Yes,that is what I mean

在 2021年1月18日週一 下午10:08,nassau-tk [email protected] 寫道:

@sum2012 https://github.com/sum2012

Please tell me about Jpcsp. "If install our current PGF font to Jpcsp then the text will appear correctly?" Did you said mean above?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hrydgard/ppsspp/issues/11055#issuecomment-762273370, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQTT7A4JQBP62XGSMYBD6DS2Q6GZANCNFSM4FAYAM2Q .

sum2012 avatar Jan 18 '21 14:01 sum2012

um.... But,probably it's not "Italic Style" isn't it? image

nassau-tk avatar Jan 18 '21 14:01 nassau-tk

We may be fixed if we transate the jpcsp's find optium font function

在 2021年1月18日週一 下午10:30,nassau-tk [email protected] 寫道:

um.... But,probably it's not "Italic Style" isn't it? [image: image] https://user-images.githubusercontent.com/48179091/104927578-f4d5cd00-59e4-11eb-8907-cd9d061a6f88.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hrydgard/ppsspp/issues/11055#issuecomment-762285970, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQTT7HLVVP3CXOL2CN5YNTS2RAZLANCNFSM4FAYAM2Q .

sum2012 avatar Jan 18 '21 14:01 sum2012

Jpcsp logic: First find same fontStyle , We may be fixed if we transate the jpcsp's find optium font function

We have a test that validates some of the logic we use: https://github.com/hrydgard/pspautotests/blob/879e7959eb3251133fcc4ccf26b0ef35d9d43f8e/tests/font/optimum.expected

I'm not very concerned with JPCSP's logic, whether it's wrong or right, and much more concerned about matching behavior with real PSP firmware.

The game can pass in a "font style" object that has > 10 fields, and this is used to match the font. Based on tests, we match against the family, style (i.e. italic), language, country, name, and filename if specified. We also compare the H/V metrics.

If we can reproduce the style the game is requesting, we can use that to verify what the correct matching logic is. A lot of JPCSP's functions are guesswork or hacked and it looks like this is no exception. I'd rather not copy that, better to figure out how we're deviating from the correct firmware behavior.

-[Unknown]

unknownbrackets avatar Jan 18 '21 14:01 unknownbrackets

@unknownbrackets @sum2012

Oh!? Really? I'm not setting info about bold & Italic on my PGF font files. I will fixed them A.S.A.P..

nassau-tk avatar Jan 18 '21 14:01 nassau-tk

I fixed property of font style. I will make PR later.

[jpn0.pgf] PGF header: header_len: 0188 version : 6.2 font name : Source Han Sans font type : Regular

[kr0.pgf] PGF header: header_len: 0188 version : 6.2 font name : Source Han Sans font type : Regular

[ltn0.pgf] PGF header: header_len: 0188 version : 6.2 font name : Ume Hy Gothic font type : Regular

[ltn1.pgf] PGF header: header_len: 0188 version : 6.2 font name : Ume P Mincho font type : Regular

[ltn2.pgf] PGF header: header_len: 0188 version : 6.2 font name : Ume Hy Gothic font type : Italic

[ltn3.pgf] PGF header: header_len: 0188 version : 6.2 font name : Ume P Mincho font type : Italic

[ltn4.pgf] PGF header: header_len: 0188 version : 6.2 font name : Ume Hy Gothic font type : Bold

[ltn5.pgf] PGF header: header_len: 0188 version : 6.2 font name : Ume P Mincho font type : Bold

[ltn6.pgf] PGF header: header_len: 0188 version : 6.2 font name : Ume Hy Gothic font type : Bold Italic

[ltn7.pgf] PGF header: header_len: 0188 version : 6.2 font name : Ume P Mincho font type : Bold Italic

and loop untill ltn15.pgf

nassau-tk avatar Jan 19 '21 01:01 nassau-tk

In some ways I wonder if it'd be best to lie and use the font names of the original fonts.

-[Unknown]

unknownbrackets avatar Jan 19 '21 01:01 unknownbrackets

Is that meaning that we should try to camouflage for font name? Is that right?

nassau-tk avatar Jan 19 '21 02:01 nassau-tk