nvim-cmp icon indicating copy to clipboard operation
nvim-cmp copied to clipboard

Published 20 hours ago • verified publisher icon hrsh7th

feat: `config.view.entries.vertical_positioning = 'above'|'below'|'auto'`

Open llllvvuu opened this issue 1 year ago • 18 comments

Also applies to docs_view otherwise the docs will cover the text when it is significantly taller than the completion menu.

For Copilot, 'above' works best with vim.opt.scrolloff = 999.

Fixes: #495 Helped-by: Thanatermesis [email protected]

llllvvuu avatar Sep 12 '23 23:09 llllvvuu

Best feature ever, I'm running directly off of your branch now... its perfect.

barnacker avatar Oct 09 '23 21:10 barnacker

Thanks! I just fixed it yesterday to fix the docs preview as well

ping @hrsh7th for review

llllvvuu avatar Oct 10 '23 02:10 llllvvuu

Thanks! I just fixed it yesterday to fix the docs preview as well

ping @hrsh7th for review

Can we even expect any reviews on this? I mean, we still on v0.0.1 with no releases for a long time and no recent activity

idelice avatar Oct 14 '23 10:10 idelice

@hrsh7th What's the deal on this? I'd love to have this merged...

I constantly run into overlapping prompts and if this fixes it, I'd be super happy.

lcrownover avatar Dec 02 '23 03:12 lcrownover

also waiting for this

franroa avatar Dec 09 '23 19:12 franroa

I also cloned your repo, hope it gets merged soon.

valenmarton avatar Jan 14 '24 20:01 valenmarton

@hrsh7th can we please get this reviewed?

smitropoulos avatar Feb 16 '24 00:02 smitropoulos

I think it is useful feature. I heard his thoughts before.

But he don't want to add new features now. Because new features increases maintenance cost. He might change his mind though.

He wants to include bug fix only.

Shougo avatar Feb 16 '24 06:02 Shougo

This is also a bugfix for a very annoying bug that I constantly run into where the completion window covers up the text if your screen isn't large enough.

lcrownover avatar Feb 16 '24 07:02 lcrownover

This is also a bugfix for a very annoying bug that I constantly run into where the completion window covers up the text if your screen isn't large enough.

agree

franroa avatar Feb 16 '24 07:02 franroa

@hrsh7th are you still maintaining this repo or not?

idelice avatar Feb 21 '24 10:02 idelice

It is still maintaining. The responses are slow though. You can see other issues and PRs.

Shougo avatar Mar 27 '24 12:03 Shougo

I merged this with main from nvim/cmp so it has the latest changes and can be merged, PR is here: https://github.com/llllvvuu/nvim-cmp/pull/1. This was because I wanted multi line ghost text together with the option to put the cmp window above

michaelbrusegard avatar Jun 08 '24 13:06 michaelbrusegard

Forks who are using copilot now can use copilot-cmp with my pr which add multi-line ghost-text and dynamic window flip capability, I has been using it for 2 month, hope there are few bugs https://github.com/hrsh7th/nvim-cmp/pull/1955

xzbdmw avatar Jun 09 '24 00:06 xzbdmw