hrsh7th comments

Results 335 comments of


                                            hrsh7th

Snippet source shows up in preview before confirming

No, the implementation allows you to omit the argument. https://github.com/hrsh7th/nvim-cmp/blob/main/lua/cmp/init.lua#L132

feat: add option for view to follow cursor

IMO, it should be `custom_entries_view` only feature. The native menu is a bit complicated, so I would like to exclude it from the list and annotate docs.

feat: add option for view to follow cursor

LGTM. Thank you.

Favor existing values in completion_item over resovled_completion_item

I didn't know it was specified in the LSP specification! thank you.

Astro LSP completions sometimes write over incorrect ranges

This issue already solved in latest @astrojs/language-server

Setting mapping in `cmp.setup.cmdline({'/', '?'}, {` prevents command tab completion from working after search

I'm sorry, but this is the specification. In Vim's cmdline mode, key mappings for : and / are not separated by namespace, so enabling cmp for / also enables key...

Select nth item in the completion list, and number items

I think it can be supported via `formatting.format` function. Why do you add this to the core?

Select nth item in the completion list, and number items

I really appreciate the contribution, but I'm not really a fan of this feature. . . Can you tell us about the superiority of this function?

Please, comment code, this is a major issue

I don't think adding comments to the current codebase would make anything better. Adding something like a diagram might be a good idea. BTW, there are plans to separate the...

Allow window.documentation.max_{width, height} to be set to 0

Looks good. Could you resolve conflicts?