Hannes Roest

I have added a few more functions and tests, especially around the memory view: Memoryview is about 3x faster than copying into numpy arrays and about 200x faster than using...

See https://github.com/OpenMS/OpenMS/blob/5c51ad02b833986049f250c1cb46fe02b77b79cc/src/pyOpenMS/pxds/Types.pxd#L25 so `Size` should be `size_t` - so that makes me wonder if the Windows version is 32 bit? Otherwise, if its compiled for 64 bit then I would...

@timosachsenberg is there a way you can test this, eg with large integers in Python?

I think what happened was that `getModification()` used to return a String: cdaced522fd5f112440d1b123d66f1b1dc The issue now is that sorting is not stable, eg AASequence may be sorted differently on different...

I think on Windows we link statically anyways right? Anyways, I think the correct approach here is to prevent libraries to be included in downstream tools, eg if someone wants...

Yes, have a look https://github.com/OpenMS/OpenMS/blob/develop/src/openms/include/OpenMS/FORMAT/HANDLERS/XMLHandler.h -- in its current implementation there is no way to separate XMLHandler from `xercesc` since it inherits from `xercesc::DefaultHandler` and that is how the parser...

> Totally agree on your second point. So the catches are xerces objects and full declarations in our public API right? @jpfeuffer yes this is what gets included https://github.com/OpenMS/OpenMS/blob/8fb42eca245b70bc79818a4f37e6243f67225c1a/src/openms/include/OpenMS/FORMAT/HANDLERS/XMLHandler.h#L45-L48 so...

@jpfeuffer yes, we have to inherit from the xerces handler in order to get the callback right. I dont think tinkering with OPENMS_DLLAPI would be the right approach since i)...

@timosachsenberg you could simply remove the check for empty values here on line 142 and therefore allow empty values which a user could now generate with "wrap-x: wrap-y: Now some...

this is a known issue with autowrap but since there are no "const" objects in Python, leaving out the const keyword does not change much in practice