Hannah Robarts
Hannah Robarts
Thank you for the review @MargaretDuff :)
> Thanks for updating that Hannah! I am happy to approve. > > Might suggest that we try and add some more comments to the unit tests so that if...
Thank you for the review Gemma, I think all the comments are resolved now
Hi Jakob, yes we can avoid it. I thought it already was a dependency but I can remove it if not
Thanks for the discussion @jakobsj , @paskino , @gfardell , @casperdcl We discussed: - It makes more sense to keep the Paganin-like filter functionality in the same class as the...
After chatting with Gemma, latest suggestion is to add a new argument to get_output so the user can specify if they want the full retrieval or just the filter ```...
Updates from discussion with @gfardell - Could remove the `geometry_unit_multiplier` argument and require the user to specify the units in the geometry, as we already have a parameter for this...
Hi Laura, this is looking good! I've been thinking about how we can use the size of the mask to determine which dimensions to loop over. I think something like...
I checked the documentation and it looks fine. I added the labels separately but can remove them if we don't want them in the user-facing docs. I also re-checked some...
We discussed pros and cons of using a separate class for NormalisationData versus including flat and darkfields in AcquistionData **NormalisationData** Suggested structure: ``` AcquisitionData Array Geometry IsNormalised boolean NormalisationData FlatField...