pcollections

pcollections copied to clipboard

convenience methods for creating multi-element collections

1

see #89 — would be nice to add `HashTreePMap.of`, `TreePVector.of` et cetera, a la Java's `Map.of` and `List.of` methods

hrldcpr

add a utility method for deep conversion from java collections

4

Thank you for this great library that makes good stuff from Clojure available to Java developers. In the context of my book [Data-Oriented programming](https://www.manning.com/books/data-oriented-programming), I am considering to use `pcollections`...

viebel

Potential DoS via PCollections

4

I'd rather not disclose details yet to prevent zero-day. @hrldcpr what is your preferred channel to report security-related issues?

ignasi35

As in #74, recursive implementations can lead to stack overflows for large collections. - [x] #82 fix ConsPStack overflows mentioned in https://github.com/Albul/benchmarks-java-kotlin - [ ] find all the problematic uses...

hrldcpr

…for example in `minus` and `minusAll` methods, if nothing is removed then ideally the original collection should be returned. Same for `plusAll(empty())` - [ ] find any methods that don't...

hrldcpr

TreePVector is slow

2

_From [[email protected]](https://code.google.com/u/100694777776169671086/) on 2009-03-30T02:18:33Z_ according to tests.Benchmarks, TreePVector is the only PCollection which consistently underperforms compared to its corresponding Java API class, ArrayList. 2-3 finger trees might provide a faster...

blackdrag

_From [[email protected]](https://code.google.com/u/100694777776169671086/) on 2009-03-16T21:47:42Z_ might be faster than current size-balanced-tree implementation (more optimized for integer keys) might also lead to better PVector implementation? PQueue? cf http://www.haskell.org/ghc/docs/latest/html/libraries/containers/Data-IntMap.html http://www.haskell.org/ghc/docs/latest/html/libraries/containers/Data-Sequence.html http://www.haskell.org/ghc/docs/latest/html/libraries/containers/ _Original issue:...

blackdrag

Implement sequenced collection interfaces

1

Now that we've dropped Java 8 support... how about moving to Java 21? 😂 A rudimentary implementation might look like [this](https://github.com/prdoyle/pcollections/commit/e10cb255cb6ab552def96544e31767a4b46e0c19). (The implementation of [`OrderedPMap.reversed()`](https://github.com/prdoyle/pcollections/blob/e10cb255cb6ab552def96544e31767a4b46e0c19/src/main/java/org/pcollections/OrderedPMap.java#L145) is inefficient, essentially making a...

prdoyle

`OrderedPSet::contains` is O(N) as it inherits from `AbstractSet::contains`

1

`OrderedPSet` should override `Set::contains` as follows: ``` @Override public boolean contains(Object o) { return ids.containsKey(o); } ``` In the absence of this override, the class inherits the method from `AbstractSet`,...

oxbowlakes

`OrderedPMap::containsKey` is O(N) as it inherits from `AbstractMap::containsKey`

1

`OrderedPMap` should override `containsKey` as follows: ``` @Override public boolean containsKey(Object key) { return ids.containsKey(key); } ``` In the absence of this override, the class inherits the method from `AbstractMap`,...

oxbowlakes