ncspot icon indicating copy to clipboard operation
ncspot copied to clipboard

Save track/album/playlist and Follow Artist not working

Open ekattsim opened this issue 1 year ago • 7 comments

Describe the bug A clear and concise description of what the bug is. Attempting to save a track/album/playlist or to follow an artist leads to no response and does not appear in the library.

To Reproduce Multiple ways to reproduce the behavior:

  • Use the default 's' keybind on a selected item.
  • Use the vim-like command ":save" on a selected item.
  • Use the vim-like command ":save current" to attempt saving the playing track.
  • Use the context menu of a track and select save.
  • Use the context menu of a track, select artist, then follow artist.

Expected behavior After saving an item, the item needs to appear in the dedicated section of the library.

Screenshots N/A

System (please complete the following information):

  • OS: MacOS
  • Terminal: WezTerm
  • Version: 1.2.1
  • Installed from: brew

Backtrace/Debug log Never crashed, N/A

Additional context I thought at first, there must be an issue preventing writes to spotify since everything else was working but I was able to add tracks to playlists with no problem.

Thanks.

ekattsim avatar Dec 12 '24 05:12 ekattsim

Hmm, I'm having trouble reproducing it. Just searched for an artist and saved, also was able to save a track from the "On Repeat" playlist to my liked songs.

Can you check if there's a backtrace in your cache folder?

hrkfdn avatar Dec 22 '24 18:12 hrkfdn

here's a backtrace, i'm not sure from when:

0: std::backtrace::Backtrace::force_capture
1: ncspot::panic::register_backtrace_panic_handler::{{closure}}
2: std::panicking::rust_panic_with_hook
3: std::panicking::begin_panic_handler::{{closure}}
4: std::sys::backtrace::__rust_end_short_backtrace
5: _rust_begin_unwind
6: core::panicking::panic_fmt
7: core::result::unwrap_failed
8: std::sys::backtrace::__rust_begin_short_backtrace
9: core::ops::function::FnOnce::call_once{{vtable.shim}}
10: std::sys::pal::unix::thread::Thread::new::thread_start
11: __pthread_start


panicked at src/library.rs:272:32:
called `Result::unwrap()` on an `Err` value: Any { .. }

I tried removing the file and performing the save actions to see if a new backtrace gets populated but nothing.

The save function still doesn't do anything, let me know what else I can do to help you debug. Thanks.

ekattsim avatar Dec 23 '24 01:12 ekattsim

Hello, I,m having the same problem here. System : MXLinux, Debian12 ncspot installation : cargo build --release --features cover,notify,share_clipboard ncspot version : ncspot 1.2.1 (8638ee3)

Everything else is fine, thanks for your work.

The backtrace file seems irrelevant, it hasn't been touched since a long time. Thanks.

plkrbb avatar Dec 23 '24 16:12 plkrbb

Does this also happen to you with the main branch?

hrkfdn avatar Dec 23 '24 16:12 hrkfdn

afaik, i'm in the main branch - my terminal prompt shows :
%ncspot git:main ❯ and i launch ncspot with :
target/release/ncspot or am I wrong ? Thanks.

plkrbb avatar Dec 23 '24 17:12 plkrbb

afaik, i'm in the main branch - my terminal prompt shows : %ncspot git:main ❯ and i launch ncspot with : target/release/ncspot or am I wrong ? Thanks.

That's the release. Do something like this:

git clone https://github.com/hrkfdn/ncspot.git && cd ncspot
cargo build --no-default-features --features portaudio_backend,pancurses_backend,share_clipboard,mpris,notify
./debug/ncspot --version
ncspot 1.2.1 (37b4fc9)

Unfortunately, the issue still persists on the main branch.

ekattsim avatar Dec 23 '24 17:12 ekattsim

Thank you, I tried this (with the debug instance), but it still won't save tracks or albums on my system. Anyway it's not really a problem for now, I can still use my phone app for this purpose :) Cheers.

plkrbb avatar Dec 23 '24 18:12 plkrbb