jfa-go icon indicating copy to clipboard operation
jfa-go copied to clipboard

Invite Links

Open TheKnarf247 opened this issue 7 months ago • 4 comments

Read the FAQ first!

Describe the bug

When creating invite links hitting the copy button produces and invite url "/invite/dczFxPMmpTnsvJpo3r8b7H" but when emailed it creates the url correctly "http://mydomain//invite/dczFxPMmpTnsvJpo3r8b7H"

To Reproduce

running latest unstable release, setup the same as the stable release

Logs contain nothing but the action of creating/sending the link If you're using a build with a tray icon, right-click on it and press "Open logs" to access your logs.

When you notice the problem, check the output of jfa-go or get the logs by pressing the "Logs" button in the Settings tab. If the problem is not obvious (e.g a panic (red text) or 'ERROR' log), re-run jfa-go with the -debug argument and reproduce the problem. You should then take a screenshot of the output, or paste it here, preferably between ``` tags (e.g ````Log here\``). Remember to censor any personal information.

If nothing catches your eye in the log, access the admin page via your browser, go into the console (Right click > Inspect Element > Console), refresh, reproduce the problem then paste the output here in the same way as above.

Configuration

If you see it as necessary, include relevant sections of your config.ini, for example, include [email] and [smtp]|[mailgun] if you have an email issue.

Platform/Version latest unstable, windows 64 Include the platform jfa-go is running on (e.g Windows, Linux, Docker), the version (first line of output by jfa-go or Settings>About in web UI), and if necessary the browser version and platform.

TheKnarf247 avatar May 18 '25 10:05 TheKnarf247

The same problem

joacoarguelles avatar May 18 '25 15:05 joacoarguelles

Since this is causing loads of issues for everyone i've made it generate URLs based on the "External jfa-go URL" value set in settings, rather than the URL you're accessing the admin page at in commit 0fd3981. Try that and make sure the value is set correctly.

hrfee avatar May 27 '25 14:05 hrfee

Since this is causing loads of issues for everyone i've made it generate URLs based on the "External jfa-go URL" value set in settings, rather than the URL you're accessing the admin page at in commit 0fd3981. Try that and make sure the value is set correctly.

this has made having dynamic links not possible, i use jfa-go on two domains and now i cant have set "External jfa-go URL" to domain A and access jfa-go in domain B it redirects to domain A for some of those urls. is it possible to be optional? we would have nginx forward the host headers proxy_set_header Host $host; and use them if "External jfa-go URL" isnt set.

MuhammadBayiz avatar Jun 07 '25 20:06 MuhammadBayiz

Since this is causing loads of issues for everyone i've made it generate URLs based on the "External jfa-go URL" value set in settings, rather than the URL you're accessing the admin page at in commit 0fd3981. Try that and make sure the value is set correctly.

this has made having dynamic links not possible, i use jfa-go on two domains and now i cant have set "External jfa-go URL" to domain A and access jfa-go in domain B it redirects to domain A for some of those urls. is it possible to be optional? we would have nginx forward the host headers proxy_set_header Host $host; and use them if "External jfa-go URL" isnt set.

I've added in 7cb66e2 a option "Use reverse-proxy reported "Host" when possible" which I hope will fix this for you. Make sure your reverse proxy includes the Host, X-Forwarded-Host and X-Forwarded-Proto/X-Forwarded-Protocol headers. Let me know if it works for you, and of course this option only affects links generated in the web app (like invites), and server-generated links like those sent in messages will still use "External jfa-go URL".

hrfee avatar Jul 16 '25 14:07 hrfee