QuakeInjector icon indicating copy to clipboard operation
QuakeInjector copied to clipboard

Failed download file remains

Open SpiritQuaddicted opened this issue 10 years ago • 3 comments

If a download fails, the file will be kept in the download directory. If the user tries to install again, the file will be used and if it was incomplete the user will get an error message.

There should be an option to remove the broken file somehow.

SpiritQuaddicted avatar Sep 14 '14 12:09 SpiritQuaddicted

What error does it give in that case? I get something like "gzip stream error" in some maps. This may be the cause.

hkBattousai avatar Sep 14 '14 13:09 hkBattousai

If I recall correctly something about a stream.

SpiritQuaddicted avatar Sep 17 '14 09:09 SpiritQuaddicted

I thought about it and see no reason to keep a broken file. The QI does not resume downloads (and should not, based on filesize it has no way of knowing if the file has been replaced upstream or if it actually resumes).

It might be nice to verify the md5sum after downloading but generally we can trust that a download either succeeds or results in an error message. If error, then delete.

SpiritQuaddicted avatar Aug 10 '15 19:08 SpiritQuaddicted