QuakeInjector icon indicating copy to clipboard operation
QuakeInjector copied to clipboard

Mention the package or at least line in which a parsing error occured

Open SpiritQuaddicted opened this issue 4 years ago • 2 comments

The Injector should mention the package or at least the line in the XML when a parsing occurs. For example for bad dates instead of 'Database parsing failed! XML Parsing Error: Date Malformed' it should rather say 'Database parsing failed for package: example! XML Parsing Error: Date Malformed' and/or 'Database parsing failed in line 123! XML Parsing Error: Date Malformed'

This would make it more clear for both users and Quaddicted editors what the issue is.

SpiritQuaddicted avatar Jun 12 '21 08:06 SpiritQuaddicted

How do I reproduce this? I tried to break database.xml but the program just redownloads it again

demoth avatar Jul 18 '22 19:07 demoth

It requires some hacking of the source, easiest would probably be changing the URL in https://github.com/hrehfeld/QuakeInjector/blob/34195c1a2eb49c59789f21e9fdb8a1dfd9ca0ee8/src/main/java/de/haukerehfeld/quakeinjector/Configuration.java#L103 and hosting it on localhost or something. Then serve a file with e. g. a & instead of a & for package authors. That should trigger an error.

SpiritQuaddicted avatar Jul 19 '22 07:07 SpiritQuaddicted