wayback icon indicating copy to clipboard operation
wayback copied to clipboard

remaining work

Open hrbrmstr opened this issue 8 years ago • 4 comments

Finishing up the CDX API wrapper: https://github.com/internetarchive/wayback/tree/master/wayback-cdx-server

then error/edge-case handling + writing tests + code coverage

full-disclosure: seekrit project (i suck at seekrit projects) is a FOSS book on web scraping. Full credit in book and package to all who contribute.

hrbrmstr avatar Feb 27 '17 02:02 hrbrmstr

I'll have a play.

jonocarroll avatar Feb 27 '17 03:02 jonocarroll

I added some is_* helpers today since I was waiting for an online student to arrive to class and got tired of poking at Microsoft.

hrbrmstr avatar Feb 28 '17 22:02 hrbrmstr

Looking good. I'll fiddle with internals later in the week, but I'm hoping things like

if ("timestamp" %in% colnames(res)) {
   res <- dplyr::mutate_(res, "timestamp" = lazyeval::interp(~anytime::anytime(t), t = quote(timestamp)))
}

replaced with

res <- dplyr::mutate_at(res, dplyr::vars(dplyr::matches("timestamp")), dplyr::funs(anytime::anytime))

makes sense/is desired. The failing test (if there is no timestamp column) leaves res unchanged.

jonocarroll avatar Feb 28 '17 23:02 jonocarroll

+1. I kinda get lazy in my pkgs and do a globalVariables() hack

hrbrmstr avatar Feb 28 '17 23:02 hrbrmstr