linalg icon indicating copy to clipboard operation
linalg copied to clipboard

Modified Gesv to accept nil pivots and complex matrices

Open jvlmdr opened this issue 12 years ago • 3 comments

Hey, a few minor modifications:

I've let Gesv() accept a nil argument for ipiv according to the spec. Gesv() will also now call zgesv() if the arguments are complex. I didn't add this for other functions e.g. Gels(). The symbols cdotusub and zdotusub weren't found on OS X. Added linux/darwin switches for cgo. Removed dependency on atlas. Ran gofmt.

Let me know if you'd like only a subset of these.

jvlmdr avatar Jul 02 '13 04:07 jvlmdr

At the moment I could do without the gofmt part. It looks like it changes all the lines. Personally I have used indentation of 4 with spaces.

hrautila avatar Jul 05 '13 00:07 hrautila

(Thanks for the work you've done on this library!)

I can understand not wanting to have a singularity in your commit history where everything changed but nothing changed. This is the problem that gofmt is supposed to solve though!

jvlmdr avatar Jul 05 '13 04:07 jvlmdr

Unfortunately gofmt can be invoked with parameters :) I used following when I originally run gofmt to the libbary: gofmt -w -tabs=false -tabwidth=4 $*

hrautila avatar Jul 06 '13 00:07 hrautila