Squot icon indicating copy to clipboard operation
Squot copied to clipboard

Enable coverage testing

Open fniephaus opened this issue 7 years ago • 4 comments

I've tried to enable coverage testing, see https://github.com/hpi-swa/Squot/commit/7f889691a1e5689b179a4fb12ff248bfd67c9647. Unfortunately, smalltalkCI fails because of this, for a stack trace see here.

fniephaus avatar Nov 07 '17 09:11 fniephaus

Stoopid metaprogramming breaks my brittle caller reflection, how sad! And I thought I would not make that #warn:-mistake again. Guess I should turn that warning into a comment, right?

j4yk avatar Nov 07 '17 18:11 j4yk

No, you probably want:

TemporaryGitStamp class>>new

	self error: 'You should use #ensureDefaultValues to create an instance of TemporaryGitStamp'

and

TemporaryGitStamp class>>ensureDefaultValues
	"Register some values for tests and return an instance of me
	that can subsequently be used to restore the previous values."
	| tempStamp |
	tempStamp := self basicNew initialize.
	self defaultName: 'John Doe'.
	self defaultEmail: '[email protected]'.
	^ tempStamp name: self defaultName; email: self defaultEmail; yourself

krono avatar Nov 07 '17 18:11 krono

also, you probably want example.com instead of foo.com ;)

krono avatar Nov 07 '17 18:11 krono

Yay, now the vm segfaults: https://travis-ci.org/hpi-swa/Squot/jobs/298993387

fniephaus avatar Nov 08 '17 09:11 fniephaus