schulcloud-server icon indicating copy to clipboard operation
schulcloud-server copied to clipboard

Published 20 hours ago • verified publisher icon hpi-schul-cloud

Ew 570 review comments

Open MajedAlaitwniCap opened this issue 1 year ago • 2 comments

Description

image

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • [ ] DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • [ ] QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • [ ] All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

MajedAlaitwniCap avatar Feb 26 '24 08:02 MajedAlaitwniCap

All comments are moved to https://github.com/hpi-schul-cloud/schulcloud-server/pull/4831#pullrequestreview-1942650097 so we can clean up and merge what we already done here without to make it so much complicated every PR @alweber-cap @WahlMartin @CeEv @virgilchiriac @Metauriel

MajedAlaitwniCap avatar Mar 18 '24 11:03 MajedAlaitwniCap

I see that i had not pubished review comments. Pubished now. If you want to move they also.

CeEv avatar Mar 18 '24 13:03 CeEv

this PR Should not be merged and the work on is Merged with EW-620

MajedAlaitwniCap avatar Apr 08 '24 10:04 MajedAlaitwniCap