svelte-material-ui icon indicating copy to clipboard operation
svelte-material-ui copied to clipboard

Published 20 hours ago • verified publisher icon hperrin

`@material/theme` as a dependency?

Open marekdedic opened this issue 3 years ago • 5 comments

Is your feature request related to a problem? Please describe. Hi, it's complicated for me to track what versions of @material/theme I need to use with what version of smui. Especially if I have automatic dependency updates enabled, this gets messy pretty quickly. I recently went from v1 to v4 and needing to upgrade smui and @material/theme in lockstep was also frustrating.

Describe the solution you'd like If @material/theme were a dependency/peer-dependency, It would automatically be installed with the correct version...

marekdedic avatar Sep 14 '21 09:09 marekdedic

Possibly related: https://github.com/hperrin/svelte-material-ui/issues/348

stuft2 avatar Nov 12 '21 06:11 stuft2

I just tried removing it from my app and everything still works fine (I'm on v5) - @hperrin I could submit a PR, but honestly, I'm not sure what the right approach is? Do we need to manually install @material/theme? If so, could it be made a dependency or a peer-dependency? If so, of which package? I'd say probably @smui/common, but I'm not sure...

marekdedic avatar Jan 06 '22 11:01 marekdedic

I'm really not sure. I could make it a peer dependency. Maybe of smui/common?

hperrin avatar Jan 14 '23 03:01 hperrin

Oh maybe I can mark conflicting versions instead? So anything newer would conflict with it.

hperrin avatar Jan 14 '23 03:01 hperrin

Hi, I think making it a dependency or a peer dependency would make it easier to maintain than manually selecting conflicting versions, but either should work...

marekdedic avatar Jan 14 '23 08:01 marekdedic