HPCC-Platform icon indicating copy to clipboard operation
HPCC-Platform copied to clipboard

HPCC-33754 Bump vcpkg mongodb to latest version

Open GordonSmith opened this issue 11 months ago • 3 comments

March 2025 is failing to build on Ubuntu 22.04

Signed-off-by Gordon Smith [email protected]

Type of change:

  • [x] This change is a bug fix (non-breaking change which fixes an issue).
  • [ ] This change is a new feature (non-breaking change which adds functionality).
  • [ ] This change improves the code (refactor or other change that does not change the functionality)
  • [ ] This change fixes warnings (the fix does not alter the functionality or the generated code)
  • [ ] This change is a breaking change (fix or feature that will cause existing behavior to change).
  • [ ] This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • [x] My code follows the code style of this project.
    • [ ] My code does not create any new warnings from compiler, build system, or lint.
  • [ ] The commit message is properly formatted and free of typos.
    • [ ] The commit message title makes sense in a changelog, by itself.
    • [ ] The commit is signed.
  • [ ] My change requires a change to the documentation.
    • [ ] I have updated the documentation accordingly, or...
    • [ ] I have created a JIRA ticket to update the documentation.
    • [ ] Any new interfaces or exported functions are appropriately commented.
  • [x] I have read the CONTRIBUTORS document.
  • [ ] The change has been fully tested:
    • [ ] I have added tests to cover my changes.
    • [ ] All new and existing tests passed.
    • [ ] I have checked that this change does not introduce memory leaks.
    • [ ] I have used Valgrind or similar tools to check for potential issues.
  • [x] I have given due consideration to all of the following potential concerns:
    • [ ] Scalability
    • [ ] Performance
    • [ ] Security
    • [ ] Thread-safety
    • [ ] Cloud-compatibility
    • [ ] Premature optimization
    • [ ] Existing deployed queries will not be broken
    • [ ] This change fixes the problem, not just the symptom
    • [x] The target branch of this pull request is appropriate for such a change.
  • [ ] There are no similar instances of the same problem that should be addressed
    • [ ] I have addressed them here
    • [ ] I have raised JIRA issues to address them separately
  • [ ] This is a user interface / front-end modification
    • [ ] I have tested my changes in multiple modern browsers
    • [ ] The component(s) render as expected

Smoketest:

  • [ ] Send notifications about my Pull Request position in Smoketest queue.
  • [ ] Test my draft Pull Request.

Testing:

GordonSmith avatar Apr 01 '25 09:04 GordonSmith

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33754

Jirabot Action Result: Workflow Transition To: Merge Pending Updated PR

github-actions[bot] avatar Apr 01 '25 09:04 github-actions[bot]

I wonder if changes like this should be implemented as two commits. I assume most of the changes are copying existing files, and then a couple of minor changes are applied to them. It would be very useful to have those separated, otherwise it isn't clear which bits have actually changed.

ghalliday avatar Apr 02 '25 14:04 ghalliday

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33754

Jirabot Action Result: Workflow Transition To: Merge Pending

github-actions[bot] avatar Apr 02 '25 14:04 github-actions[bot]

This fix has been rolled into the vcpkg v2025-04-09

GordonSmith avatar Apr 17 '25 10:04 GordonSmith

(Still needed) New PR here: https://github.com/hpcc-systems/HPCC-Platform/pull/19762

GordonSmith avatar Apr 17 '25 14:04 GordonSmith