HPCC-Platform icon indicating copy to clipboard operation
HPCC-Platform copied to clipboard

HPCC-33185 Create a Docker image for test such as Build Verification…

Open xwang2713 opened this issue 1 year ago • 2 comments

The purpose to create a Docker image is to make a consistent environment for BVT and some other HPCC test which can target various HPCC Cloud environments as well as bare-metal deployments.

This will based on platform-core and include: 1) all required software 2) HPCC-Platform source 3) Test scripts for BVT and result handling 4) Some other basic tests

For Github Action related code I change "ml" to "extra" to reflect these additional Docker images not only for ML but also for others such as test, etc. These changes are in action.yml, buildall.sh and build-and-publish.yml

One of the reason choosing Docker image instead of putting these code to Github Action scripts are:

  1. It is much easy to debug, test and implement test code
  2. The Docker image can be used in much wilder test environment specially can be run in restrict network environment which Github Action can't reach Signed off

Type of change:

  • [ ] This change is a bug fix (non-breaking change which fixes an issue).
  • [x] This change is a new feature (non-breaking change which adds functionality).
  • [ ] This change improves the code (refactor or other change that does not change the functionality)
  • [ ] This change fixes warnings (the fix does not alter the functionality or the generated code)
  • [ ] This change is a breaking change (fix or feature that will cause existing behavior to change).
  • [ ] This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • [x] My code follows the code style of this project.
    • [x] My code does not create any new warnings from compiler, build system, or lint.
  • [x] The commit message is properly formatted and free of typos.
    • [ ] The commit message title makes sense in a changelog, by itself.
    • [ ] The commit is signed.
  • [ ] My change requires a change to the documentation.
    • [ ] I have updated the documentation accordingly, or...
    • [ ] I have created a JIRA ticket to update the documentation.
    • [ ] Any new interfaces or exported functions are appropriately commented.
  • [ ] I have read the CONTRIBUTORS document.
  • [ ] The change has been fully tested:
    • [ ] I have added tests to cover my changes.
    • [ ] All new and existing tests passed.
    • [ ] I have checked that this change does not introduce memory leaks.
    • [ ] I have used Valgrind or similar tools to check for potential issues.
  • [ ] I have given due consideration to all of the following potential concerns:
    • [ ] Scalability
    • [ ] Performance
    • [ ] Security
    • [ ] Thread-safety
    • [ ] Cloud-compatibility
    • [ ] Premature optimization
    • [ ] Existing deployed queries will not be broken
    • [ ] This change fixes the problem, not just the symptom
    • [ ] The target branch of this pull request is appropriate for such a change.
  • [ ] There are no similar instances of the same problem that should be addressed
    • [ ] I have addressed them here
    • [ ] I have raised JIRA issues to address them separately
  • [ ] This is a user interface / front-end modification
    • [ ] I have tested my changes in multiple modern browsers
    • [ ] The component(s) render as expected

Smoketest:

  • [ ] Send notifications about my Pull Request position in Smoketest queue.
  • [ ] Test my draft Pull Request.

Testing:

Test from my private tag: https://github.com/xwang2713/HPCC-Platform/tree/community_33185_5

Github action workflows https://github.com/xwang2713/HPCC-Platform/actions/runs/13166761406

Docker images: https://hub.docker.com/repositories/xwang2713 All images have tag: 9.10.3-closedown0 Generated images: platform-test, platform-ml, platform-gnn and platform-gnn-gpu

xwang2713 avatar Feb 06 '25 15:02 xwang2713

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33185

Jirabot Action Result: Assigning user: [email protected] Workflow Transition To: Merge Pending Updated PR

github-actions[bot] avatar Feb 06 '25 15:02 github-actions[bot]

@Michael-Gardner, as current we can use this Docker Image for generic HPCC Cloud test which is why I call it "platform-test". I can mention it in 2/11 Q/A meeting.

xwang2713 avatar Feb 11 '25 13:02 xwang2713

@GordonSmith this is waiting for your review. @xwang2713 this will need rebasing.

ghalliday avatar May 29 '25 11:05 ghalliday

@xwang2713 - what does this achieve that running ./dockerfiles/image.sh doesn't give you?

GordonSmith avatar May 30 '25 16:05 GordonSmith

Closing due to no response from @xwang2713

ghalliday avatar Jun 26 '25 15:06 ghalliday