HPCC-Platform icon indicating copy to clipboard operation
HPCC-Platform copied to clipboard

HPCC-29356 add JIRA creation guidelines to userdocs

Open cloLN opened this issue 1 year ago • 6 comments

Type of change:

  • [ ] This change is a bug fix (non-breaking change which fixes an issue).
  • [x] This change is a new feature (non-breaking change which adds functionality).
  • [ ] This change improves the code (refactor or other change that does not change the functionality)
  • [ ] This change fixes warnings (the fix does not alter the functionality or the generated code)
  • [ ] This change is a breaking change (fix or feature that will cause existing behavior to change).
  • [ ] This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • [x] My code follows the code style of this project.
    • [x] My code does not create any new warnings from compiler, build system, or lint.
  • [x] The commit message is properly formatted and free of typos.
    • [x] The commit message title makes sense in a changelog, by itself.
    • [ ] The commit is signed.
  • [ ] My change requires a change to the documentation.
    • [ ] I have updated the documentation accordingly, or...
    • [ ] I have created a JIRA ticket to update the documentation.
    • [ ] Any new interfaces or exported functions are appropriately commented.
  • [ ] I have read the CONTRIBUTORS document.
  • [ ] The change has been fully tested:
    • [ ] I have added tests to cover my changes.
    • [ ] All new and existing tests passed.
    • [ ] I have checked that this change does not introduce memory leaks.
    • [ ] I have used Valgrind or similar tools to check for potential issues.
  • [ ] I have given due consideration to all of the following potential concerns:
    • [ ] Scalability
    • [ ] Performance
    • [x] Security
    • [x] Thread-safety
    • [ ] Cloud-compatibility
    • [ ] Premature optimization
    • [ ] Existing deployed queries will not be broken
    • [ ] This change fixes the problem, not just the symptom
    • [ ] The target branch of this pull request is appropriate for such a change.
  • [ ] There are no similar instances of the same problem that should be addressed
    • [ ] I have addressed them here
    • [ ] I have raised JIRA issues to address them separately
  • [ ] This is a user interface / front-end modification
    • [ ] I have tested my changes in multiple modern browsers
    • [ ] The component(s) render as expected

Smoketest:

  • [ ] Send notifications about my Pull Request position in Smoketest queue.
  • [ ] Test my draft Pull Request.

Testing:

cloLN avatar Sep 16 '24 17:09 cloLN

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-29356

Jirabot Action Result: Workflow Transition To: Merge Pending Updated PR

github-actions[bot] avatar Sep 16 '24 17:09 github-actions[bot]

@cloLN this is waiting for you to update it...

ghalliday avatar Oct 04 '24 10:10 ghalliday

@cloLN this is still waiting for you...

ghalliday avatar Dec 04 '24 13:12 ghalliday

@cloLN - this one seems stalled, waiting for you to squash by the looks of it?

jakesmith avatar Jan 30 '25 16:01 jakesmith

@cloLN your force push removed the last commit rather than squashing them.

Oof. Let me try again.

cloLN avatar Feb 19 '25 13:02 cloLN

I'm not quite sure how to roll back my changes. Suggestions? Should I try to revert changes in git or should I proceed with what I have here as it should fix all the concerns in the previous comments? @ghalliday

cloLN avatar Feb 19 '25 16:02 cloLN