HPCC-20686 Add regression suite option to delete workunits at end of run

[Goutami-Sooda]

Type of change:

• [ ] This change is a bug fix (non-breaking change which fixes an issue).
• [x] This change is a new feature (non-breaking change which adds functionality).
• [ ] This change improves the code (refactor or other change that does not change the functionality)
• [ ] This change fixes warnings (the fix does not alter the functionality or the generated code)
• [ ] This change is a breaking change (fix or feature that will cause existing behavior to change).
• [ ] This change alters the query API (existing queries will have to be recompiled)

Checklist:

• [x] My code follows the code style of this project.
  • [x] My code does not create any new warnings from compiler, build system, or lint.
• [x] The commit message is properly formatted and free of typos.
  • [x] The commit message title makes sense in a changelog, by itself.
  • [x] The commit is signed.
• [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly, or...
  • [ ] I have created a JIRA ticket to update the documentation.
  • [ ] Any new interfaces or exported functions are appropriately commented.
• [x] I have read the CONTRIBUTORS document.
• [x] The change has been fully tested:
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] I have checked that this change does not introduce memory leaks.
  • [ ] I have used Valgrind or similar tools to check for potential issues.
• [ ] I have given due consideration to all of the following potential concerns:
  • [ ] Scalability
  • [x] Performance
  • [ ] Security
  • [ ] Thread-safety
  • [ ] Cloud-compatibility
  • [ ] Premature optimization
  • [x] Existing deployed queries will not be broken
  • [ ] This change fixes the problem, not just the symptom
  • [x] The target branch of this pull request is appropriate for such a change.
• [ ] There are no similar instances of the same problem that should be addressed
  • [ ] I have addressed them here
  • [ ] I have raised JIRA issues to address them separately
• [ ] This is a user interface / front-end modification
  • [ ] I have tested my changes in multiple modern browsers
  • [ ] The component(s) render as expected

Smoketest:

• [ ] Send notifications about my Pull Request position in Smoketest queue.
• [ ] Test my draft Pull Request.

Testing:

The newly added cleanup functionality after Regression Test has been tested out on local build of HPCC Systems. It works as expected and no issues have been noticed yet. The added feature enables RTE users to choose automatic cleanup of workunits created by Regression Test.

[Goutami-Sooda]

@AttilaVamos I request you to kindly review the pull request and suggest changes to the code if any

[Goutami-Sooda]

Except the new file CleanUp.md I can't see any further changes related to my previous comments.

We have made changes to the cleanup.py and ecl-test files along with adding the CleanUp.md file. We have optimized the the getRegressLogs() and getWorkunitDetails(). We modified the code to obtain logDir from the config instead of ecl-test.json file as per your suggestion.

[AttilaVamos]

@Goutami-Sooda Can you share with me how did you commit your changes and push those commits (the command used)? I can see 7 commits, but if I switch to the files I can't see the differences between the commits.

[Goutami-Sooda]

@Goutami-Sooda Can you share with me how did you commit your changes and push those commits (the command used)? I can see 7 commits, but if I switch to the files I can't see the differences between the commits.

We used regular git commit and git push commands to push the changes. The changes made by each commit can be viewed by clicking on each commit from the commits section. If you want to see the overall changes made since last review, it can be viewed from files section by choosing the filter to view changes made since last review.

[Goutami-Sooda]

@ghalliday We request you to kindly review the changes and merge the pull request to the original HPCC-Platform repository.