ColossalAI icon indicating copy to clipboard operation
ColossalAI copied to clipboard

fix: wrong dp-rank condition when enable pp

Open liuqh16 opened this issue 5 months ago • 0 comments

📌 Checklist before creating the PR

  • [ ] I have created an issue for this PR for traceability
  • [ ] The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • [ ] I have added relevant tags if possible for us to better distinguish different PRs
  • [ ] I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Fix the wrong dp-rank condition when enable pp:

  • If dp>1 and pp>1, execute rl_example will raise an ZeroDivisionError error because self.accum_count only accums when self.dp_rank==0 in grpo_consumer.py.

💥 Checklist before requesting a review

  • [ ] I have linked my PR to an issue (instruction)
  • [ ] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • [x] I have performed a self-review of my code
  • [ ] I have added thorough tests.
  • [ ] I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • [x] 🌝 Yes, I do.
  • [ ] 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

liuqh16 avatar Jul 30 '25 10:07 liuqh16