ColossalAI icon indicating copy to clipboard operation
ColossalAI copied to clipboard

[fix] launching error on special env variables (#6032)

Open GCS-ZHN opened this issue 1 month ago • 0 comments

📌 Checklist before creating the PR

  • [x] I have created an issue for this PR for traceability
  • [x] The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • [x] I have added relevant tags if possible for us to better distinguish different PRs
  • [x] I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

#6032

📝 What does this PR do?

Replace double quotation with single quotation to wrapper env variables during building launch command, to avoid some special variables defined in users' client.

💥 Checklist before requesting a review

  • [x ] I have linked my PR to an issue (instruction)
  • [x] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • [x] I have performed a self-review of my code
  • [x] I have added thorough tests.
  • [x] I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • [x] 🌝 Yes, I do.
  • [ ] 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

GCS-ZHN avatar Dec 31 '24 10:12 GCS-ZHN