Enhancements in test_llama_attention.py / floating-point comparison, variable naming, and code cleanup
Summary The test_llama_attention. In the py script, a tolerance was incorporated in comparison of two floats to solve the problem of equality. Also, one of the variables was accidentally named like Pythonβs keyword which is prohibited, another small unnecessary local variables were eliminated that increase readability and maintainability.
Related Issues Floating-point comparison inaccuracies. Conflicting variable naming issues.
Discussions Discussed the possible enhancements in comparing floats and in nomenclature.
QA Instructions Perform test script runs on floating point compare validation models to gain maximum accuracy of the test results.
Merge Plan Run some routines to check that the changes of floating-point tolerance and variable naming are valid before merging.
Motivation and Context The objective was to deal with precise issues with floating-point comparison problems, name clashes as well as increasing code compactness with an aim of making it more comprehensible and more maintainable.
Types of Changes Bug fix: Scientific computations absolute tolerance comparison. Code quality improvement: Renaming of variables and elimination of statements that do not have a real purpose.
π Checklist before creating the PR
- [x] I have created an issue for this PR for traceability
- [x] The title follows the standard format:
[doc/gemini/tensor/...]: A concise description - [ ] I have added relevant tags if possible for us to better distinguish different PRs
- [ ] I have installed pre-commit:
pip install pre-commit && pre-commit install
π¨ Issue number
Link this PR to your issue with words like fixed to automatically close the linked issue upon merge
e.g.
fixed #1234,closed #1234,resolved #1234
π What does this PR do?
Summarize your work here. if you have any plots/diagrams/screenshots/tables, please attach them here.
π₯ Checklist before requesting a review
- [ ] I have linked my PR to an issue (instruction)
- [x] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
- [x] I have performed a self-review of my code
- [ ] I have added thorough tests.
- [ ] I have added docstrings for all the functions/methods I implemented
βοΈ Do you enjoy contributing to Colossal-AI?
- [x] π Yes, I do.
- [ ] π No, I don't.
Tell us more if you don't enjoy contributing to Colossal-AI.