ColossalAI icon indicating copy to clipboard operation
ColossalAI copied to clipboard

[Feature] Add Galore (Adam, Adafactor) and distributed GaloreAdamW8bit

Open Edenzzzz opened this issue 10 months ago • 2 comments

📌 Checklist before creating the PR

  • [ ] I have created an issue for this PR for traceability
  • [ ] The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • [ ] I have added relevant tags if possible for us to better distinguish different PRs
  • [ ] I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

#5443

📝 What does this PR do?

  • Add galore_torch integration from the galore paper repo
  • Add an efficient distributed implementation compatible with DDP and TP

💥 Checklist before requesting a review

  • [ ] I have linked my PR to an issue (instruction)
  • [ ] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • [ ] I have performed a self-review of my code
  • [ ] I have added thorough tests.
  • [ ] I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • [ ] 🌝 Yes, I do.
  • [ ] 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

Edenzzzz avatar Apr 08 '24 11:04 Edenzzzz

Great! When could it be merged? Thanks a lot.

ericxsun avatar Apr 29 '24 06:04 ericxsun

Great! When could it be merged? Thanks a lot.

Most likely by May 1st

Edenzzzz avatar Apr 29 '24 08:04 Edenzzzz