ColossalAI icon indicating copy to clipboard operation
ColossalAI copied to clipboard

Published 20 hours ago • verified publisher icon hpcaitech

[PROPOSAL]: [save_model] function in [ppo.py] is duplicated

Open ddobokki opened this issue 2 years ago • 0 comments

Proposal

https://github.com/hpcaitech/ColossalAI/blob/d7bf284706ef256c38d3aad53142b07cfc0fc10e/applications/Chat/coati/trainer/ppo.py#L210

https://github.com/hpcaitech/ColossalAI/blob/d7bf284706ef256c38d3aad53142b07cfc0fc10e/applications/Chat/coati/trainer/ppo.py#L213

Probably a simple mistake, it need to clear one.

Self-service

  • [X] I'd be willing to do some initial work on this proposal myself.

ddobokki avatar Apr 22 '23 08:04 ddobokki