ColossalAI
ColossalAI copied to clipboard
hpcaitech
Fixed several spelling errors under colossalai
📌 Checklist before creating the PR
- [ ] I have created an issue for this PR for traceability
- [x] The title follows the standard format:
[doc/gemini/tensor/...]: A concise description - [x] I have added relevant tags if possible for us to better distinguish different PRs
🚨 Issue number
Not involved
📝 What does this PR do?
Optimization Code Fixed several spelling errors under colossalai,The code logic is not modified Note on readme.md file changes GitHub's image caching mechanism will cache images,Add a random number after the last modified link. so that every time you visit that link, the contributor's image will be refreshed in real time.
💥 Checklist before requesting a review
- [ ] I have linked my PR to an issue (instruction)
- [x] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
- [x] I have performed a self-review of my code
- [x] I have added thorough tests.
- [x] I have added docstrings for all the functions/methods I implemented
⭐️ Do you enjoy contributing to Colossal-AI?
- [x] 🌝 Yes, I do.
- [ ] 🌚 No, I don't.
Tell us more if you don't enjoy contributing to Colossal-AI.
Hi @digger-yu Thanks for the contribution. Could you please fix above comments? Thanks.
sorry,I don't understand too well, what I need to do ?
Hi @digger-yu Don't worry. You can update these changes according to above comments at digger-yu:main, then we will review it. Thanks.
Hi @digger-yu Thank you for your careful contribution. I have reviewed all the content and think it is pretty nice! I would suggest you fix the bugs according to the above comments first at your branch, and then I can merge this PR. Because Colossal-AI is in high-speed development, modifying too many files at one time is likely to cause conflicts with other contributors' PRs, causing unnecessary extra work. For example, you can split your further PR according to the path, docs/example/colossalai/application/etc. Thanks.
@binmakeswell It's an honor to contribute to the open source world. I'll go through it all as soon as I can, it's almost done. Most of the changes are actually words in comments. The individual changes like Usgae::Usage:: are related to the code logic. But I think this is just to restore the function of its design.
all done.please check
Hi @digger-yu Could you please fix bugs according to comments at the beginning of this PR first, rather than adding new changes? It may only take a few minutes. You've modified almost a hundred files at once, which is a lot for a PR. Although these changes aren't related to the code logic, unfortunately, some of them are incorrect, and we should fix them before merging this PR. Thank you very much.
@binmakeswell Sorry for the trouble you caused question 1 :it just add a random number to make sure that each visit is the latest list of images and not cached, it is effective question 2 :Already revert
@binmakeswell Sorry for the trouble you caused question 1 :it just add a random number to make sure that each visit is the latest list of images and not cached, it is effective question 2 :Already revert
oh, I'm so sorry, I forgot to submit the review comments and you actually cannot read them before. Thank you very much for your patience and contribution.