ColossalAI icon indicating copy to clipboard operation
ColossalAI copied to clipboard

[revert] recover "[refactor] restructure configuration files (#2977)"

Open FrankLeeeee opened this issue 1 year ago • 0 comments

📌 Checklist before creating the PR

  • [x] I have created an issue for this PR for traceability
  • [x] The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • [x] I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

partial fix for #3012 fixed #3016

📝 What does this PR do?

Summarize your work here. if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR fixed the PyTorch not found error during installation. The root cause is the usage of pyproject.toml. Despite the fact that pyproject.toml is a newer version of python build tool, it introduces some new features which conflict with our setup.py. The underlying reason for the bug is that pyproject.toml will execute python build in an isolated environment. As a result, PyTorch cannot be found in this isolated environment, leading to installation error when CUDA_EXT=1 is provided.

There is no easy solution to fix this according to https://github.com/pypa/pip/issues/6144. Thus, it might be just good to revert this commit.

Since #3017 is related to pyproject.toml, I will just close #3017 .

💥 Checklist before requesting a review

  • [x] I have linked my PR to an issue (instruction)
  • [x] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • [x] I have performed a self-review of my code
  • [x] I have added thorough tests.
  • [x] I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • [x] 🌝 Yes, I do.
  • [ ] 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

FrankLeeeee avatar Mar 06 '23 16:03 FrankLeeeee